Closed Bug 1028496 Opened 10 years ago Closed 10 years ago

Autolink Github Compare links

Categories

(Tree Management Graveyard :: TBPL, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jhford, Assigned: emorley)

References

Details

Attachments

(1 file)

Similar to the PR# thing, let's autolink commit messages which are like this:

A link like:

https://github.com/try-server-hook/gaia/compare/c0709e95fa79...0dd22e62b96d

should turn into:
<a href="https://github.com/try-server-hook/gaia/compare/c0709e95fa79...0dd22e62b96d">gaia commits c0709e95fa79...0dd22e62b96d</a>

I have a code snippet that takes a commit message and does this with a Regexp backed replacement http://pastebin.mozilla.org/5445599
Attached patch Patch v1Splinter Review
Using the regex in the pastebin gives this patch - however it doesn't work with the format commit messages I can currently see on Staging-Gaia-Try

Are they going to change, or has the plan here changed?
They're going to change, but I don't want to put the full URL until it can be shortened on TBPL.
(In reply to John Ford [:jhford] -- please use 'needinfo?' instead of a CC from comment #2)
> They're going to change, but I don't want to put the full URL until it can
> be shortened on TBPL.

Ah ok - have pushed:
remote:   https://hg.mozilla.org/webtools/tbpl/rev/394f52535899
Assignee: nobody → emorley
Status: NEW → ASSIGNED
Depends on: 1032949
In production :-)
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Blocks: 1081041
Product: Webtools → Tree Management
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: