Closed
Bug 1028700
Opened 12 years ago
Closed 12 years ago
[keyboard] Prevent context menu event on firefox desktop
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Firefox OS Graveyard
Gaia::Keyboard
Tracking
(Not tracked)
RESOLVED
FIXED
2.0 S5 (4july)
People
(Reporter: kameron.argis, Assigned: timdream)
References
Details
(Whiteboard: [p=1])
Attachments
(2 files)
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.57 Safari/537.36
Steps to reproduce:
On FirefoxOS emulator when i long click on a letter.
Actual results:
A contextual menu appears.
Expected results:
Special keys must appear.
|
Reporter | |
Comment 1•12 years ago
|
||
|
|
Reporter | |
Comment 2•12 years ago
|
||
Attachment #8444112 -
Flags: review?(dflanagan)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 8444112 [details] [diff] [review]
1028700.patch
Tim and Rudy are more familiar with this code currently than I am, and I think Tim is in the middle of refactoring it, so I'm going to ask him to do this review (or pass it to Rudy)
Attachment #8444112 -
Flags: review?(dflanagan) → review?(timdream)
|
Assignee | |
Comment 4•12 years ago
|
||
Comment on attachment 8444112 [details] [diff] [review]
1028700.patch
This is good but we should wait for bug 1025520 before landing this so we can properly add tests to the script added.
Attachment #8444112 -
Flags: review?(timdream) → feedback+
|
|
Assignee | |
Comment 5•12 years ago
|
||
Hi Kaméron,
Would you like to re-do your patch after bug 1025520 or you want me to take over?
Assignee: nobody → kameron.argis
Mentor: timdream
Status: UNCONFIRMED → ASSIGNED
Depends on: 1025520
Ever confirmed: true
Flags: needinfo?(kameron.argis)
|
|
Reporter | |
Comment 6•12 years ago
|
||
Hi Tim,
I don't think i can re-do my patch without help , you can take over, thanks.
Flags: needinfo?(kameron.argis)
|
|
Assignee | |
Updated•12 years ago
|
Status: ASSIGNED → NEW
|
|
Assignee | |
Updated•12 years ago
|
Attachment #8449163 -
Flags: review?(rlu)
|
|
Assignee | |
Updated•12 years ago
|
Status: NEW → ASSIGNED
Component: General → Gaia::Keyboard
Whiteboard: [p=1]
Target Milestone: --- → 2.0 S5 (4july)
|
||
Comment 9•12 years ago
|
||
Comment on attachment 8449163 [details] [review]
mozilla-b2g:master PR#21251
This looks pretty good to me, and solves the annoying problem when debugging keyboard app in Nightly.
Thanks for patching this up.
Attachment #8449163 -
Flags: review?(rlu) → review+
|
|
Assignee | |
Comment 10•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•