1025520 - Move touch event handling away from keyboard.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

+++ This bug was initially created as a clone of Bug #1023729 +++

The on* functions (the touch/mouse event listeners) currently lives in keyboard.js as global functions. They should be collected to another module and cover with tests.

After this bug we should be deliver proper fix to bug 1013570 by implementing a queue to handle these events there. See bug 1015541 comment 2 for discussion.

I however not really sure we could do that in this one bug or split that to another dependent bug. A separate patch is probably better in terms of keeping the tree safe (making sure regression is identifiable between builds by QA, for example.)

Comment 2

[Mozilla Shepherd (This account is used for automation and doesn't receive bugmail)]

Attachment: mozilla-b2g:master PR#20724

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Gu is broken ...

https://tbpl.mozilla.org/?tree=Gaia-Try&rev=d3c810e56cc8e7417a253df54191c14afde82e2b

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8442592 [details] [review]
mozilla-b2g:master PR#20724

We should start the review process first.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

So Gu actually found a logic error; here is the test run of updated patch

https://tbpl.mozilla.org/?tree=Gaia-Try&rev=789899901972400b554e364d684dd8dd4311ebb2

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

BTW, it wasn't caught by manual test because the touch identifiers sent by the test are incremental, while on the actual device it is literally the nth finger on the screen.

Comment 7

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8442592 [details] [review]
mozilla-b2g:master PR#20724

Sorry for the delay, I have just started to look at this patch.

Comment 8

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8442592 [details] [review]
mozilla-b2g:master PR#20724

r=me with some comments/nits addressed.
Thank you.

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I will land this bug tomorrow when bug 1023730 finally sits safely in master.

Comment 10

[Mozilla Shepherd (This account is used for automation and doesn't receive bugmail)]

Attachment: mozilla-b2g:master PR#21226

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://tbpl.mozilla.org/?rev=2b01ddf6f0ed4021a02f52e03f00c14d9ccc6d55&tree=Gaia-Try

master: https://github.com/mozilla-b2g/gaia/commit/c8601e4313c47c8fd14cb0afbfa3f71cb12bffcb