102897 - Gap at the bottom of the link toolbar "More" menu

Status: RESOLVED EXPIRED

(SeaMonkey :: UI Design, defect)

Description

[Hixie (not reading bugmail)]

STEPS TO REPRODUCE
   http://www.bath.ac.uk/~py8ieh/internet/eviltests/link2.html
   Click on Link Toolbar: More.

ACTUAL RESULTS
   At the bottom of the menu there are a few pixels of extra whitespace that do
   not appear in other menus. This occurs both in Modern and Classic.

EXPECTED RESULTS
   The menu should act like the others.

cc'ing usual suspects as per bug 102832.

Comment 1

[Gervase Markham [:gerv]]

There's a collapsed <menuseparator/> down there... removing that fixes it.
However, it seems odd to me that it should still have height when collapsed.
Perhaps we need to do something else other than, or in addition to, collapsing it.

Gerv

Comment 2

[Boris Zbarsky [:bzbarsky]]

display:none, maybe?

Comment 3

[sairuh (rarely reading bugmail)]

cool new feature!

->claudius, since he tests toolbars.

Comment 4

[Christopher Hoess (gone)]

Perhaps we should be using "hidden" instead of "collapsed"?  It would help if the 
<menuseparator/> element was documented...

Comment 5

[Tim 'Tool-Man' Taylor]

I experienced intermittent crashes when using "hidden".  Perhaps it's a bug,
perhaps I was using it wrong (as already mentioned, the documentation is
lacking).  Anyhow, if anyone tries the "hidden" route again, please test
thoroughly, maybe running it yourself for a few days before submitting it.  It
was a bitch to track down the first time.  I believe I left a comment near the
offending code explaining why "collapsed" was used instead of hidden.

Comment 6

[:deanis74]

There's somewhat similar discussion in bug 94984, which seems to suggest using
display:none instead of visibility:collapsed.  Blake sez using hidden maps to
display:none.

Comment 7

[Gervase Markham [:gerv]]

We should be using hidden. If it crashes, we find and fix the source - we should
use the right tool for the right job.

The patch for this is basically s/collapsed/hidden/ in the relevant part of
linkToolbar.xul and some JS.

Gerv

Comment 8

[Christopher Hoess (gone)]

Attachment: Moves over to "hidden", also uses hideElement (see comments in file)

Comment 9

[Christopher Hoess (gone)]

Here's a patch.  I've also switched over to using the hideElement function (see
the comments in the file); if this works without funny crashes, we can remove
the removeElement code.

Comment 10

[Christopher Hoess (gone)]

Ok, the patch is working for me.  Review, anyone?

Comment 11

[Nobody; OK to take it and work on it]

This isn't an 0.9.5 blocker, so when other stuff gets out of my tree, I'll
review it. In the meantime, please remove the XXX and the commented-out code (we
have CVS for that) in linkToolbarItem.js.

Other than that, it looks fine from here.

Gerv

Comment 12

[Andrew Simmonds]

Attachment: same patch + cosmetic code cleanup

Comment 13

[Christopher Hoess (gone)]

Attachment: Removes all unused code.

Comment 14

[timeless]

gerv: nobody is supposed to be seen and not heard...

Comment 15

[Gervase Markham [:gerv]]

Yeah, sorry about that. There was a reason I was logged in as nobody.

Gerv

Comment 16

[[e-mail]]

Comment on attachment 52460 [details] [diff] [review]
Removes all unused code.

Nit: Correct style is to use .hidden = true/false instead of directly twiddling
attributes.

Comment 17

[Robert Kaiser]

This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 18

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but still has no comment since the inception of the SeaMonkey project 5 years ago.

Because of this, we're resolving the bug as EXPIRED.

If you still can reproduce the bug on SeaMonkey 2 or otherwise think it's still valid, please REOPEN it and if it is a platform or toolkit issue, move it to the according component.

Query tag for this change: EXPIRED-20100420