1029056 - Validate coorganizer usernames when adding them

Status: RESOLVED FIXED

(Webmaker Graveyard :: Events, defect)

Description

[Chris DeCairos (:cade)]

STR:

1. Add a fake username to be a coorganizer on an event you can edit
2. save

Expected: some kind of notification of a problem "That username doesn't exist!"

Actual: nothing happens. error logged in developer console.

Lets implement some error handling

Comment 1

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/webmaker-events-2/pull/105

Adds a usernameService for checking if a username exists.
The service is added to the event form controller, and is used before a coorganizer username is added to the list of coorganizers.

Comment 2

[inactivate account for kate]

Comment on attachment 8444673 [details] [review]
https://github.com/mozilla/webmaker-events-2/pull/105

I think it'd be better to do the validation live

Comment 3

[Chris DeCairos (:cade)]

Comment on attachment 8444673 [details] [review]
https://github.com/mozilla/webmaker-events-2/pull/105

It appears that angular's debounce functionality for model updating isn't working..

Comment 4

[inactivate account for kate]

Comment on attachment 8444673 [details] [review]
https://github.com/mozilla/webmaker-events-2/pull/105

R+

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker-events-2

https://github.com/mozilla/webmaker-events-2/commit/506236944b7d97f4093b4cc15db98c74dc7bc7c6
Bug 1029056 - Add usernameService for checking if a username exists for a requested coorganizer