Closed
Bug 1029126
Opened 10 years ago
Closed 10 years ago
Fix a warning in typed-object code (TypedObjectPrediction.cpp:332:13: warning: overflow in implicit constant conversion [-Woverflow])
Categories
(Core :: JavaScript: Standard Library, defect)
Core
JavaScript: Standard Library
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: Waldo, Assigned: Waldo)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
6.41 KB,
patch
|
shu
:
review+
|
Details | Diff | Splinter Review |
Assigning SIZE_MAX to an int32_t isn't okay. Looking closer, it turns out the assignment is unnecessary because it's for a return-false case (false indicating error), and the location can/should be size_t instead. So remove the assignment, and switch the location type to size_t. <none>
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8444679 -
Flags: review?(shu)
|
||
Updated•10 years ago
|
Attachment #8444679 -
Flags: review?(shu) → review+
|
||
Comment 3•10 years ago
|
||
[Adding warning text to make this more discoverable, to prevent folks like me from filing dupes)
Blocks: buildwarning, 1022356
Summary: Fix a warning in typed-object code → Fix a warning in typed-object code (TypedObjectPrediction.cpp:332:13: warning: overflow in implicit constant conversion [-Woverflow])
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f012527686c8
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•