1029555 - No favicon for cnn search engine if added from Page Menu

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Favicon Handling, defect, P5)

Description

[Ioana Chiorean]

Attachment: Screenshot

OS: Android 4.4.4, 4.1.2, 3.2.1
Devices: Alcatel One Touch, Nexus 4, Acer Iconia

Steps:
1. Go to cnn.com
2. Tap Menu -> Page -> Add a Search Engine (either one of the 2 will work )
3. Go back to cnn.com and long tap on the search fiedl (either one the page will work )
4. Go to Settings -> Customization -> Search 

Expected results:
- all search engines added should have a favicon

Actual Results:
- the one added from Page Menu has no favicon 
- log error: 
06-24 17:58:11.141: W/GeckoFaviconDecoder(5592): Unable to decode icon URI.

Note:
- reproducible on both phones and tablets

Comment 1

[Ioana Chiorean]

I don't think it is cnn specific problem only.

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

Check to see if this behavior regressed.

Comment 3

[Flaviu Cos]

Last good build: 2013-11-07;
First bad build: 2013-11-08;
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=70de5e24d79b&tochange=f003c386c77a

Comment 4

[Chris Kitching [:ckitching]]

Ooh, that's useful. Thanks Flaviu!

The work done for Bug 852608 looks likely to be the culprit.

Also highly suspect is:
http://hg.mozilla.org/mozilla-central/rev/57da3b6e50c7#l1.43

Might it be that this wild guess is incorrect in the case of cnn?

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

filter on [mass-p5]

Comment 6

[Mike Taylor [:miketaylr]]

The reason this fails is we're only looking for {{ uri }}/favicon.ico. CNN's is located at <link href="http://www.cnn.com/favicon.ie9.ico" rel="Shortcut Icon" type="image/x-icon"/>.

Comment 7

[Aaron Train [:aaronmt]]

Re-test this, they updated over new years and we get their new mobile site

Comment 10

[devonfyson]

This is a problem on Firefox 50.0 in Ubuntu and 49.0.2 on Android. For example go to http://wiki.openstreetmap.org/ or https://www.wikidata.org and try adding it. They both have favicons, but they both appear as generic grey icons.

Comment 11

[lmlb_lmlb]

Also with Wiktionary.

Comment 12

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 13

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.