1029631 - Enable touch-action on Nightly for platforms that support touch events

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Blink will have touch-action enabled for touch events (but may not have pointer events).
We should investigate if the current touch-action implementation works well enough
with touch events, and once it does, enable touch-action on touch devices, at least.

webkit bug to implement touch-action is https://bugs.webkit.org/show_bug.cgi?id=133112

Comment 1

[Florian Bender]

May you please provide an update on what is blocking this issue? Is it just Bug 1171098?

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Mostly it's lack of time/resources. The touch-action implementation is not fully complete on the APZ side and nobody is actively working on it.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Stealing and repurposing. I think touch-action is good enough to turn on in Nightly now. I will be meeting with other vendors later this month and webcompat/interop of implementations will be one of the things we discuss. If all is well after that we can let it ride the trains in Fx 50 or (more likely) 51.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Comment 5

[Kartikaya Gupta (email:[e-mail])]

dev-platform intent-to-enable thread: https://groups.google.com/forum/#!topic/mozilla.dev.platform/SYEzvXJKw9M

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8768141 [details] [diff] [review]
Patch

Ok, so this is about Pointer Event v1 touch-action. We're missing the v2 additions.

v1
https://www.w3.org/TR/pointerevents/#the-touch-action-css-property
v2
https://w3c.github.io/pointerevents/#the-touch-action-css-property

Assuming I'm testing this right on Chrome, it doesn't ship v2 values either by default yet.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Could you please file a bug to implement the v2 stuff.

Comment 8

[Kartikaya Gupta (email:[e-mail])]

(In reply to Olli Pettay [:smaug] from comment #6)
> Assuming I'm testing this right on Chrome, it doesn't ship v2 values either
> by default yet.

Yeah, they almost turned it on a few days ago but decided to wait [1].

(In reply to Olli Pettay [:smaug] from comment #7)
> Could you please file a bug to implement the v2 stuff.

Filed bug 1285685.

[1] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/VhYxkRlfQng

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f7f37f4fd841
Enable touch-action support on Nightly for all platforms. r=smaug

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/8b52e519d715 for gtest failures:

https://treeherder.mozilla.org/logviewer.html#?job_id=31475951&repo=mozilla-inbound

Comment 11

[Phil Ringnalda (:philor)]

Also a couple of unexpected assertions on Android, https://treeherder.mozilla.org/logviewer.html#?job_id=31472835&repo=mozilla-inbound

Comment 12

[Kartikaya Gupta (email:[e-mail])]

Whoops, sorry about that. Added a couple of patches that fix the test failures: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4764eba72fbf

Comment 13

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1029631 - Make a couple of gtests touch-action-friendly.

Review commit: https://reviewboard.mozilla.org/r/63358/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/63358/

Comment 14

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1029631 - Add a missing null check.

Review commit: https://reviewboard.mozilla.org/r/63360/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/63360/

Comment 15

[Botond Ballo [:botond]]

Comment on attachment 8769454 [details]
Bug 1029631 - Make a couple of gtests touch-action-friendly.

https://reviewboard.mozilla.org/r/63358/#review60360

Comment 16

[Botond Ballo [:botond]]

Comment on attachment 8769455 [details]
Bug 1029631 - Add a missing null check.

https://reviewboard.mozilla.org/r/63360/#review60362

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/600f3ae078de
Make a couple of gtests touch-action-friendly. r=botond
https://hg.mozilla.org/integration/mozilla-inbound/rev/e16dbf89e07f
Add a missing null check. r=botond
https://hg.mozilla.org/integration/mozilla-inbound/rev/9157099559f4
Enable touch-action support on Nightly for all platforms. r=smaug

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/600f3ae078de
https://hg.mozilla.org/mozilla-central/rev/e16dbf89e07f
https://hg.mozilla.org/mozilla-central/rev/9157099559f4

Comment 19

[Eric Shepherd [:sheppy]]

This is now listed on “Experimental features in Firefox” (https://developer.mozilla.org/en-US/Firefox/Experimental_features). Since it’s unclear if it will ride the train (please let me know if that changes), it will not be listed in the standard developer release notes until that decision is made.

However, I’ve also updated the following page to note its availability in Nightly 50:

https://developer.mozilla.org/en-US/docs/Web/CSS/touch-action
https://developer.mozilla.org/en-US/docs/Web/API/PointerEvent

Comment 20

[Kartikaya Gupta (email:[e-mail])]

Thanks. There is a dev-doc-needed keyword on bug 1244402, so once this stuff is riding the trains presumably you'll get a notification from that even if I forget to let you know explicitly.