The default bug view has changed. See this FAQ.

Let touch events on windows ride the trains

RESOLVED FIXED in Firefox 52

Status

()

Core
Panning and Zooming
RESOLVED FIXED
a year ago
12 days ago

People

(Reporter: kats, Assigned: kats)

Tracking

(Depends on: 5 bugs, Blocks: 1 bug, {dev-doc-complete, feature, site-compat})

unspecified
mozilla52
All
Windows 8
dev-doc-complete, feature, site-compat
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed, relnote-firefox 52+)

Details

(Whiteboard: [gfx-noted])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

In bug 1180706 I turned on touch events for windows nightly builds. This bug is to let it ride the trains. There will be some UX tweaking needed, as well as compat testing to make sure websites that feature-detect touch events don't suddenly start misbehaving on windows touch devices.
OS: Unspecified → Windows 8
Hardware: Unspecified → All
Blocks: 1166732
Blocks: 1187439
Blocks: 1204250
Whiteboard: [gfx-noted]
Depends on: 1158087
Depends on: 806805
Keywords: dev-doc-needed, site-compat
This could be first enabled in Developer Edition as well so that webdevs will be able to test their sites easier without having to toggle the pref. I'll post the site compatibility document at some point.

# Why Mozilla doesn't have any consistent policy on experimental features? Some features are available both in Nightly and DevEdition, some are only in Nightly, some are disabled by default. That really sucks.
Depends on: 1195722
Depends on: 1249748
No longer blocks: 1166732
Duplicate of this bug: 1166732
Depends on: 1250024
Depends on: 1256339
Depends on: 1256340
Depends on: 1256344
Depends on: 1256341
(Assignee)

Updated

11 months ago
Blocks: 1255436
Marking this as a feature to help QA/relman keep track of upcoming work. 
kats are we still planning to ship apz with e10s in 48?  Should/can we prevent that for touchscreen devices? I just noticed a bug that blocks this feature shipping, and this bug is marked as blocking apz for desktop.
Flags: needinfo?(bugmail.mozilla)
Keywords: feature
We are still planning to ship APZ with e10s in 48, yes. Touch support on Windows will not ship in 48, it is still being worked on. This bug is marked as blocking bug 1013364 ("apz-desktop") but that's a very general meta bug for all desktop apz-related things. The 48 blockers list is hanging off bug 1254668 (and is empty).
Flags: needinfo?(bugmail.mozilla)
Thanks, that clarifies things! I'll keep it in mind for the other bugs that come up.
(Assignee)

Updated

9 months ago
Depends on: 1147335
(Assignee)

Updated

9 months ago
Depends on: 970346
(Assignee)

Updated

9 months ago
No longer depends on: 806805
(Assignee)

Updated

9 months ago
Depends on: 1285566
No longer depends on: 970346
(Assignee)

Updated

8 months ago
Depends on: 1289432
(Assignee)

Updated

8 months ago
Blocks: 861876
(Assignee)

Updated

8 months ago
Depends on: 1162771
(Assignee)

Updated

8 months ago
Blocks: 1235207
(Assignee)

Updated

8 months ago
Depends on: 1000985

Updated

8 months ago
Depends on: 1272268
(Assignee)

Updated

8 months ago
Blocks: 769114
(Assignee)

Updated

8 months ago
No longer depends on: 1000985
(Assignee)

Updated

8 months ago
Blocks: 1272268
No longer depends on: 1272268
Depends on: 1261709

Updated

8 months ago
Blocks: 1197161
(Assignee)

Updated

7 months ago
Depends on: 1292572
(Assignee)

Updated

7 months ago
Depends on: 1292904
(Assignee)

Updated

7 months ago
Depends on: 1298102
(Assignee)

Updated

7 months ago
Depends on: 1298130
Depends on: 1298704
(Assignee)

Updated

7 months ago
Depends on: 1298886
(Assignee)

Updated

7 months ago
Depends on: 1298908
(Assignee)

Updated

7 months ago
Depends on: 1299243
(Assignee)

Updated

7 months ago
Depends on: 1299239
(Assignee)

Updated

7 months ago
Depends on: 1299286
(Assignee)

Updated

7 months ago
Depends on: 1299305
(Assignee)

Updated

7 months ago
Depends on: 1299625
(Assignee)

Updated

7 months ago
Depends on: 1300218
(Assignee)

Updated

7 months ago
Depends on: 1293483
(Assignee)

Updated

7 months ago
Depends on: 1300723
(Assignee)

Updated

7 months ago
Depends on: 1292900
(Assignee)

Updated

7 months ago
Depends on: 1300203
(Assignee)

Updated

7 months ago
Depends on: 1300878
(Assignee)

Updated

7 months ago
Depends on: 1300905
(Assignee)

Updated

6 months ago
Depends on: 1302736
(Assignee)

Updated

6 months ago
Depends on: 1302737
(Assignee)

Updated

6 months ago
Depends on: 1291381
(Assignee)

Updated

6 months ago
No longer depends on: 1292900
Depends on: 1304263
Depends on: 1304703
(Assignee)

Updated

6 months ago
Depends on: 1304729
This is getting close to done. Once all the things that are currently inflight land I'd be happy to flip the switch and let this ride the trains. There are still some outstanding bugs blocking this one but I don't consider any of those ship-blockers and at least some of them can be worked on further and uplifted before this goes to release.

Unfortunately the accessibility rewrite is still ongoing and so e10s is still not yet enabled by default on touch devices so we're still not getting a lot of users exercising this code.
(Assignee)

Updated

6 months ago
Depends on: 1306634
(Assignee)

Updated

6 months ago
Depends on: 1307252
(Assignee)

Updated

6 months ago
Assignee: nobody → bugmail
Comment hidden (mozreview-request)
Note that this patch enables:
- DOM touchevents on platforms that don't have it already (windows)
- APZ touch scrolling on platforms that don't have it already (windows)
- touch-action on all platforms (windows, linux, android)
- accessible caret on all platforms that don't have it already (windows, linux)

Comment 9

6 months ago
mozreview-review
Comment on attachment 8797705 [details]
Bug 1244402 - Allow touch events on Windows to ride the trains.

https://reviewboard.mozilla.org/r/83358/#review81890
Attachment #8797705 - Flags: review?(jmathies) → review+

Comment 10

6 months ago
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6955ebc6baf1
Allow touch events on Windows to ride the trains. r=jimm
I also sent an intent to ship to dev-platform: https://groups.google.com/d/msg/mozilla.dev.platform/6CGjsm1XpD4/GDbW6mCDAQAJ

Comment 12

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6955ebc6baf1
Status: NEW → RESOLVED
Last Resolved: 6 months ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Posted the site compatibility doc: https://www.fxsitecompat.com/en-CA/docs/2016/touch-event-support-has-been-re-enabled-on-windows-desktop/
Release Note Request (optional, but appreciated)
[Why is this notable]:
[Affects Firefox for Android]:
[Suggested wording]:
[Links (documentation, blog post, etc)]:
relnote-firefox: --- → ?
Depends on: 1322349
relnote-firefox: ? → 52+
(Assignee)

Updated

3 months ago
Blocks: 1325851
(Assignee)

Updated

3 months ago
Depends on: 1328285
(Assignee)

Updated

3 months ago
No longer depends on: 1299286
I've added a note into all appropriate pages under the touch events docs to make the change clear (see https://developer.mozilla.org/en-US/docs/Web/API/Touch_events). 

I've also added a note to the Firefox 52 release notes to cover it:

https://developer.mozilla.org/en-US/Firefox/Releases/52#DOM_HTML_DOM

Please let me know if this description works for you. Thanks!
Keywords: dev-doc-needed → dev-doc-complete
That works, thanks!

Comment 17

2 months ago
ff version 53.0a2 (2017-02-08)
When I installed 53 version touch events were working. But till yesterday | today update. Now again they are not firing up (
Can you check in about:support to see what it says for "Multiprocess Windows" and for "Asynchronous Pan/Zoom"?

Comment 19

2 months ago
Multiprocess Windows 	0/1 (Disabled by accessibility tools)
Asynchronous Pan/Zoom	none
Touch events are only available if e10s and APZ are on. For you it seems that they are off, because of accessibility tools. I know that the e10s team is still working on hammering out the accessibility problems. For now you can force-enable e10s by adding a pref browser.tabs.remote.force-enable in about:config and setting it to true.

Comment 21

2 months ago
> For now you can force-enable e10s by adding a pref browser.tabs.remote.force-enable in about:config and setting it to true.

Following your instructions yeah - they're again firing up. Thanks!

its strange, i didn't opt anything in these days. Updates were auto when starting-up ff. And suddenly it turned that features off?

Comment 22

16 days ago
As far as I can tell, css touch-action is now enabled (see #8) even when electrolysis is disabled. (Test: http://tests.caniuse.com/?feat=css-touch-action with google translator for firefox addon.) Could this please be mentioned in the release notes?
Flags: needinfo?(cmills)
(In reply to Luke from comment #22)
> As far as I can tell, css touch-action is now enabled (see #8) even when
> electrolysis is disabled. (Test:
> http://tests.caniuse.com/?feat=css-touch-action with google translator for
> firefox addon.) Could this please be mentioned in the release notes?

Ah, you are talking about this:

https://developer.mozilla.org/en-US/docs/Web/CSS/touch-action

?

I've looked into this, and it looks like work is still ongoing, see these bugs:

https://bugzilla.mozilla.org/show_bug.cgi?id=960316
https://bugzilla.mozilla.org/show_bug.cgi?id=1285685
Flags: needinfo?(cmills)

Comment 24

12 days ago
(In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #23)
> Ah, you are talking about this:
> 
> https://developer.mozilla.org/en-US/docs/Web/CSS/touch-action
> 
> ?
> 
> I've looked into this, and it looks like work is still ongoing, see these
> bugs:
> 
> https://bugzilla.mozilla.org/show_bug.cgi?id=960316
> https://bugzilla.mozilla.org/show_bug.cgi?id=1285685
Yep, that's the one :) Some related work is indeed ongoing, but in my opinion isn't significant here for developers:

bug 960316 is the meta bug for implementing the pointer events specification. Touch-action is defined in the pointer events specification but it's a distinct property with applicability to touch events, most notably the touch-action:manipulation trick for bypassing the 300ms click delay. (In fact even Safari supports this, Firefox is the last.) The actual implementation bug (bug 795567) is long resolved and the meta bug states that touch-action may be shipped before pointer events.

bug 1285685 is the bug for implementing the new values added to the touch-action property in the pointer events level 2 draft spec. In my opinion that shouldn't be a blocker for announcing level 1 support, the current W3C recommendation.

I also point to the intent to ship touch-action (all platforms) that references this bug as the enabler: https://groups.google.com/forum/#!topic/mozilla.dev.platform/6CGjsm1XpD4
Some of these arguments are also stated in the intent to enable touch-action on nightly for FF50:
https://groups.google.com/forum/#!topic/mozilla.dev.platform/SYEzvXJKw9M

Perhaps kats disagrees but it seems like an oversight to me...
Luke is correct. We should probably add touch-action to the dev notes for 52.
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #25)
> Luke is correct. We should probably add touch-action to the dev notes for 52.

OK, cool. Thanks to Luke for the detailed explanation that made sense of it all, and to kats for chiming in ;-)

I have added a note to the release notes under CSS/New features:

https://developer.mozilla.org/en-US/Firefox/Releases/52#New_features

I have pointed to the intent to ship mails fthe full story, rather than to specific bug(s), as I think it makes more sense if you read those.

Comment 27

12 days ago
LGTM, thanks Chris!
You need to log in before you can comment on or make changes to this bug.