Closed Bug 1029704 Opened 6 years ago Closed 6 years ago

rc3.d/ symlinks should refresh on initscript updates for runner and buildbot

Categories

(Infrastructure & Operations Graveyard :: CIDuty, task)

x86
macOS
task
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ianconnolly, Assigned: ianconnolly)

References

Details

Attachments

(1 file)

Problem arose from previous backed-out deploy from Bug 712206 and then the subsequent second deploy.
This solves problem on my own slave. 

As an aside, the fact there's no nicer way to express this in puppet is an utter pain.
Attachment #8445450 - Flags: review?(dustin)
Comment on attachment 8445450 [details] [diff] [review]
fix for runner + buildbot init.d updates

This is to fix new deploys?  Otherwise, assuming that the initscrpits have been deployed just about everywhere in the last few hours, I don't think this will do anything.

The patch looks fine - maybe I'm just missing the purpose :)

P.S. I think that 'resetpriorities' is a heck of a lot more elegant than what I was envisioning while I was ignorant of that command!
Attachment #8445450 - Flags: review?(dustin) → review+
(In reply to Dustin J. Mitchell [:dustin] from comment #2)
> Comment on attachment 8445450 [details] [diff] [review]
> fix for runner + buildbot init.d updates
> 
> This is to fix new deploys?  Otherwise, assuming that the initscrpits have
> been deployed just about everywhere in the last few hours, I don't think
> this will do anything.
> 
> The patch looks fine - maybe I'm just missing the purpose :)
> 
> P.S. I think that 'resetpriorities' is a heck of a lot more elegant than
> what I was envisioning while I was ignorant of that command!

There are a subset of slaves that got the backed out deploy previously (and thus have Runner installed already), and have a S51Runner symlink that wasn't updated by the new patch. I think :catlee cleaned them all up manually, this is just to prevent the problem re-occurring in the future.
Attachment #8445450 - Flags: checked-in?
Status: NEW → ASSIGNED
Comment on attachment 8445450 [details] [diff] [review]
fix for runner + buildbot init.d updates

http://hg.mozilla.org/build/puppet/rev/e73c170c85d5
Attachment #8445450 - Flags: checked-in? → checked-in+
Comment on attachment 8445450 [details] [diff] [review]
fix for runner + buildbot init.d updates

Mis applied to production -- backed out and applied to default:
  http://hg.mozilla.org/build/puppet/rev/5d323717c986
This was backed out from default by :dustin as it was never applied to production. Going to re-attempt a full landing today.
Attachment #8445450 - Flags: checked-in+ → checked-in?
Attachment #8445450 - Flags: checked-in? → checked-in+
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Component: Platform Support → Buildduty
Product: Release Engineering → Infrastructure & Operations
Product: Infrastructure & Operations → Infrastructure & Operations Graveyard
You need to log in before you can comment on or make changes to this bug.