1029704 - rc3.d/ symlinks should refresh on initscript updates for runner and buildbot

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: CIDuty, task)

Description

[Ian Connolly [:ianconnolly]]

Problem arose from previous backed-out deploy from Bug 712206 and then the subsequent second deploy.

Comment 1

[Ian Connolly [:ianconnolly]]

Attachment: fix for runner + buildbot init.d updates

This solves problem on my own slave. 

As an aside, the fact there's no nicer way to express this in puppet is an utter pain.

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8445450 [details] [diff] [review]
fix for runner + buildbot init.d updates

This is to fix new deploys?  Otherwise, assuming that the initscrpits have been deployed just about everywhere in the last few hours, I don't think this will do anything.

The patch looks fine - maybe I'm just missing the purpose :)

P.S. I think that 'resetpriorities' is a heck of a lot more elegant than what I was envisioning while I was ignorant of that command!

Comment 3

[Ian Connolly [:ianconnolly]]

(In reply to Dustin J. Mitchell [:dustin] from comment #2)
> Comment on attachment 8445450 [details] [diff] [review]
> fix for runner + buildbot init.d updates
> 
> This is to fix new deploys?  Otherwise, assuming that the initscrpits have
> been deployed just about everywhere in the last few hours, I don't think
> this will do anything.
> 
> The patch looks fine - maybe I'm just missing the purpose :)
> 
> P.S. I think that 'resetpriorities' is a heck of a lot more elegant than
> what I was envisioning while I was ignorant of that command!

There are a subset of slaves that got the backed out deploy previously (and thus have Runner installed already), and have a S51Runner symlink that wasn't updated by the new patch. I think :catlee cleaned them all up manually, this is just to prevent the problem re-occurring in the future.

Comment 4

[hwine]

Comment on attachment 8445450 [details] [diff] [review]
fix for runner + buildbot init.d updates

http://hg.mozilla.org/build/puppet/rev/e73c170c85d5

Comment 5

[hwine]

Comment on attachment 8445450 [details] [diff] [review]
fix for runner + buildbot init.d updates

Mis applied to production -- backed out and applied to default:
  http://hg.mozilla.org/build/puppet/rev/5d323717c986

Comment 6

[Ian Connolly [:ianconnolly]]

This was backed out from default by :dustin as it was never applied to production. Going to re-attempt a full landing today.