1029725 - breakdown: implement prompting API for search engine changes

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Mike Connor [:mconnor]]

See the URL for a lightweight spec/overview of what's been discussed.  This would be paired with a formal policy requirement that search add-ons must use the prompt API to request user changes.

This should be pretty straightforward to implement.

Comment 1

[Marco Mucci [:MarcoM]]

Added to Iteration 34.1

Comment 2

[Matthew N. [:MattN]]

Can we use this as an opportunity to clean up the mess of currentEngine and defaultEngine and have them use the same code paths for getting and setting (unless setting is removed of course)? There's also the defaultenginename pref but that's needed for the default on new profiles IIUC.

Comment 3

[Mike Connor [:mconnor]]

I think it'd be valuable to rethink defaultEngine vs. currentEngine.  Restoring defaultEngine to be a distinct value would be useful in identifying bad actors.  And Gavin and I talked about changing the pref name to break existing code paths, to explicitly break existing code that overrides those values.  Not sure that all fits in this scope, but I'm in favour of making the mess go away.

Comment 4

[Drew Willcoxon :adw]

Breakdown complete.