Closed Bug 1029725 Opened 5 years ago Closed 5 years ago

breakdown: implement prompting API for search engine changes

Categories

(Firefox :: Search, defect)

defect
Not set
Points:
3

Tracking

()

RESOLVED FIXED
Iteration:
34.1

People

(Reporter: mconnor, Assigned: adw)

References

()

Details

See the URL for a lightweight spec/overview of what's been discussed.  This would be paired with a formal policy requirement that search add-ons must use the prompt API to request user changes.

This should be pretty straightforward to implement.
Flags: firefox-backlog?
Flags: firefox-backlog? → firefox-backlog+
Points: --- → 3
Summary: API change: implement prompting API for search engine changes → breakdown: implement prompting API for search engine changes
QA Whiteboard: [qa-]
Added to Iteration 34.1
Assignee: nobody → adw
Status: NEW → ASSIGNED
Iteration: --- → 34.1
Can we use this as an opportunity to clean up the mess of currentEngine and defaultEngine and have them use the same code paths for getting and setting (unless setting is removed of course)? There's also the defaultenginename pref but that's needed for the default on new profiles IIUC.
I think it'd be valuable to rethink defaultEngine vs. currentEngine.  Restoring defaultEngine to be a distinct value would be useful in identifying bad actors.  And Gavin and I talked about changing the pref name to break existing code paths, to explicitly break existing code that overrides those values.  Not sure that all fits in this scope, but I'm in favour of making the mess go away.
Depends on: 1047687
Depends on: 1047688
Breakdown complete.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.