1029777 - Redirect runner logging output to /var/log/runner.log

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: CIDuty, task)

Comment 1

[Chris AtLee [:catlee]]

we'll need to rotate logs and delete them eventually as well.

Comment 2

[Ian Connolly [:ianconnolly]]

(In reply to Chris AtLee [:catlee] from comment #1)
> we'll need to rotate logs and delete them eventually as well.

Got any suggestions for time-to-rotate and how many we should keep before deleting?

Comment 3

[Chris AtLee [:catlee]]

No special preferences.

Rotate every boot? Keep 10 previous logs, gzip'ed?

Comment 4

[Ian Connolly [:ianconnolly]]

Attachment: logging.diff

This should do what we want to do.

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8447280 [details] [diff] [review]
logging.diff

Review of attachment 8447280 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with that change

::: modules/runner/templates/runner.initd.erb
@@ +37,2 @@
>      ### XXX -n 1 for testing
> +    if ${CMD} -c ${CONFIG} -n 1 ${TASKDIR} > /var/log/runner.log 2>&1; then

You probably want >> here

Comment 6

[Ian Connolly [:ianconnolly]]

Hrm, even with the logrotate -f line forcing a log rotation (and thus an empty file) directly above?(In reply to Dustin J. Mitchell [:dustin] from comment #5)
> Comment on attachment 8447280 [details] [diff] [review]
> logging.diff
> 
> Review of attachment 8447280 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r+ with that change
> 
> ::: modules/runner/templates/runner.initd.erb
> @@ +37,2 @@
> >      ### XXX -n 1 for testing
> > +    if ${CMD} -c ${CONFIG} -n 1 ${TASKDIR} > /var/log/runner.log 2>&1; then
> 
> You probably want >> here

Hrm, even with the logrotate -f line forcing a log rotation (and thus an empty file) directly above?

Comment 7

[Ian Connolly [:ianconnolly]]

Attachment: logging.diff

Carrying the r+ over from :dustin.