1029811 - mach build hangs on my machine

Status: RESOLVED WORKSFORME

(Firefox Build System :: General, defect)

Description

[Robert Longson [:longsonr]]

56:28.15 WARNING: mkdir -dot- requested by c:/mozilla-build/mozmake/mozmake.EXE
-C c:/moz2/mozilla-inbound/obj-i686-pc-mingw32/ipc/app export
56:28.85 Makefile:70: codegen.pp: No such file or directory
56:29.44 CSS2PropertiesProps.h
58:06.46 Creating stub file dom_quickstubs.cpp
58:06.46 Creating header file dom_quickstubs.h
58:06.46 Creating makedepend file .deps/dom_qsgen.pp
58:07.59 Creating makedepend file .deps/event_impl_gen.pp

There are several mozMakes running but they don't seem to be doing anything. It hangs every time at this spot.

Comment 1

[Gregory Szorc [:gps]]

Did you try clobbering and/or rebooting?

Comment 2

[Robert Longson [:longsonr]]

This is a completely clean build, it consistently hangs at that point. I've updated to the latest mozilla-build too.

Comment 3

[Robert Longson [:longsonr]]

I've rebooted and have set off another clean build. I'll let you know how it went later.

Comment 4

[Robert Longson [:longsonr]]

Attachment: .mozconfig

Comment 5

[Robert Longson [:longsonr]]

Hangs at exactly the same point after rebooting. What should I do now?

Comment 6

[Robert Longson [:longsonr]]

With mk_add_options MOZ_MAKE_FLAGS="-j1" in .mozconfig it seems to hang here. There are still 7 mozmake processes running/hanging, shouldn't there only be one?

700:05.54 cd results; c:/mozilla-build/mozmake/mozmake.EXE private_export
700:05.99 There are no private exports.
700:06.04 cd store; c:/mozilla-build/mozmake/mozmake.EXE private_export
700:06.42 There are no private exports.
700:06.48 cd top; c:/mozilla-build/mozmake/mozmake.EXE private_export
700:06.83 There are no private exports.
700:06.89 cd util; c:/mozilla-build/mozmake/mozmake.EXE private_export
700:07.24 There are no private exports.
700:07.30 There are no private exports.
700:07.36 cd pkix_pl_nss; c:/mozilla-build/mozmake/mozmake.EXE private_export
700:07.72 cd pki; c:/mozilla-build/mozmake/mozmake.EXE private_export
700:08.08 There are no private exports.
700:08.13 cd system; c:/mozilla-build/mozmake/mozmake.EXE private_export
700:08.50 There are no private exports.
700:08.55 cd module; c:/mozilla-build/mozmake/mozmake.EXE private_export
700:08.93 There are no private exports.
700:08.98 There are no private exports.
700:09.04 There are no private exports.
700:10.08 There are no private exports.

After pressing ctrl^c it printed this...

764:11.40 Traceback (most recent call last):
764:11.40   File "c:/moz2/mozilla-inbound/js/src/builtin/embedjs.py", line 169,
in <module>
764:11.40     main()
764:11.40   File "c:/moz2/mozilla-inbound/js/src/builtin/embedjs.py", line 165,
in main
764:11.40     msgs = preprocess(cxx, options.p, MSGS_TEMPLATE % { 'msgs': option
s.m })
764:11.42   File "c:/moz2/mozilla-inbound/js/src/builtin/embedjs.py", line 121,
in preprocess
764:11.42     if (not os.path.exists(cxx[0])):
764:11.42 IndexError: list index out of range
764:11.42 Makefile:410: recipe for target 'selfhosted.out.h' failed
764:11.42 mozmake.EXE[5]: *** [selfhosted.out.h] Error 1

This is the place it fell over before when using pymake (see bug 1028678)

Comment 7

[Gregory Szorc [:gps]]

What's in your mozconfig?

Comment 8

[Robert Longson [:longsonr]]

I attached it to the bug earlier.

Comment 9

[Robert Longson [:longsonr]]

rebuilding without cleaning hangs with this final message:

 2:15.96 c:/moz2/mozilla-inbound/obj-i686-pc-mingw32/_virtualenv/Scripts/python.
exe c:/moz2/mozilla-inbound/config/nsinstall.py -t -m 644 'js-config.h' '../../d
ist/include'
 2:16.20 c:/moz2/mozilla-inbound/obj-i686-pc-mingw32/_virtualenv/Scripts/python.
exe c:/moz2/mozilla-inbound/js/src/builtin/embedjs.py -DFFI_BUILDING -D_CRT_RAND
_S -DENABLE_PARALLEL_JS -DENABLE_BINARYDATA -DENABLE_SHARED_ARRAY_BUFFER -DJSGC_
FJGENERATIONAL -DEXPORT_JS_API -DJS_HAS_CTYPES -DDLL_PREFIX='""' -DDLL_SUFFIX='"
.dll"' -DUSE_SYSTEM_MALLOC=1 -DENABLE_ASSEMBLER=1 -DNO_NSPR_10_SUPPORT -DUSE_ZLI
B -DMOZILLA_VERSION='"33.0a1"' -DMOZILLA_VERSION_U='33.0a1' -DMOZILLA_UAVERSION=
'"33.0"' -DMOZJS_MAJOR_VERSION='33' -DMOZJS_MINOR_VERSION='0' -D_CRT_SECURE_NO_W
ARNINGS='1' -D_CRT_NONSTDC_NO_WARNINGS='1' -DHAVE_WINSDKVER_H='1' -DWINVER='0x50
2' -D_WIN32_WINNT='0x502' -D_WIN32_IE='0x0603' -DMOZ_WINSDK_TARGETVER='0x0601000
0' -DMOZ_NTDDI_WIN7='0x06010000' -DHAVE_LOCALECONV='1' -DHAVE_HYPOT='1' -DX_DISP
LAY_MISSING='1' -DMOZILLA_VERSION='"33.0a1"' -DMOZILLA_VERSION_U='33.0a1' -DMOZI
LLA_UAVERSION='"33.0"' -DMOZJS_MAJOR_VERSION='33' -DMOZJS_MINOR_VERSION='0' -D_C
RT_SECURE_NO_WARNINGS='1' -D_CRT_NONSTDC_NO_WARNINGS='1' -DHAVE_WINSDKVER_H='1'
-DWINVER='0x502' -D_WIN32_WINNT='0x502' -D_WIN32_IE='0x0603' -DMOZ_WINSDK_TARGET
VER='0x06010000' -DMOZ_NTDDI_WIN7='0x06010000' -DHAVE_LOCALECONV='1' -DHAVE_HYPO
T='1' -DX_DISPLAY_MISSING='1' -DHAVE_SNPRINTF='1' -D_WINDOWS='1' -DWIN32='1' -DX
P_WIN='1' -DXP_WIN32='1' -DHW_THREADS='1' -DSTDC_HEADERS='1' -DWIN32_LEAN_AND_ME
AN='1' -DNO_X11='1' -D_X86_='1' -DD_INO='d_ino' -DJS_CPU_X86='1' -DJS_NUNBOX32='
1' -DJS_ION='1' -DMOZ_DEBUG_SYMBOLS='1' -DNS_ATTR_MALLOC='' -DNS_WARN_UNUSED_RES
ULT='' -DMALLOC_H='<malloc.h>' -DHAVE_FORCEINLINE='1' -DHAVE_LOCALECONV='1' -DMO
Z_UPDATE_CHANNEL='default' -DNIGHTLY_BUILD='1' -DJS_THREADSAFE='1' -DZLIB_IN_MOZ
GLUE='1' -DMOZ_MEMORY='1' -DMOZ_MEMORY_DEBUG='1' -DMOZ_MEMORY_WINDOWS='1' -DJSGC
_INCREMENTAL='1' -DJSGC_GENERATIONAL='1' -DJSGC_USE_EXACT_ROOTING='1' -DJS_CODEG
EN_X86='1' -DJS_DEBUG='1' -DJS_GC_ZEAL='1' -DJS_DEFAULT_JITREPORT_GRANULARITY='3
' -DCPP_THROW_NEW='throw()' -DJS_HAS_CTYPES='1' -DMOZ_DLL_SUFFIX='".dll"' -DMOZ_
REFLOW_PERF='1' -DMOZ_REFLOW_PERF_DSP='1' -DEXPOSE_INTL_API='1' -DENABLE_INTL_AP
I='1' -DU_USING_ICU_NAMESPACE='0' -DDEBUG -DTRACING \
 2:16.21   -p 'cl -E -nologo' -m c:/moz2/mozilla-inbound/js/src/js.msg -o selfho
sted.out.h c:/moz2/mozilla-inbound/js/src/builtin/Utilities.js c:/moz2/mozilla-i
nbound/js/src/builtin/ParallelUtilities.js c:/moz2/mozilla-inbound/js/src/builti
n/Array.js c:/moz2/mozilla-inbound/js/src/builtin/Date.js c:/moz2/mozilla-inboun
d/js/src/builtin/Intl.js c:/moz2/mozilla-inbound/js/src/builtin/IntlData.js c:/m
oz2/mozilla-inbound/js/src/builtin/Iterator.js c:/moz2/mozilla-inbound/js/src/bu
iltin/Map.js c:/moz2/mozilla-inbound/js/src/builtin/Number.js c:/moz2/mozilla-in
bound/js/src/builtin/String.js c:/moz2/mozilla-inbound/js/src/builtin/Set.js c:/
moz2/mozilla-inbound/js/src/builtin/TypedObject.js

Comment 10

[Robert Longson [:longsonr]]

I backed out bug 1028678 locally and my build works again. So whether I use pymake (bug 1028678) or mach build (this bug) my build doesn't work with bug 1028678 in my tree. 

Is there any other information I can provide to determine where to go from here? At least we know the issue is with a few lines in embedjs.py now.

Comment 11

[Mike Hommey [:glandium]]

There is no patch in bug 1028678, what did you backout?

Comment 12

[Robert Longson [:longsonr]]

Oops. I backed out the patch in bug 1019955.

Comment 13

[Gregory Szorc [:gps]]

The only thing suspect I see in bug 1019955 is the subprocess call:

result = subprocess.Popen(cxx + outputArg + args + [tmpIn]).wait()
if (result != 0):
    exit(result)

Try changing this to:

subprocess.check_call(cxx + outputArg + args + [tmpIn])

(No need for the result check).

Comment 14

[Robert Longson [:longsonr]]

Attachment: js.txt

That worked!

Comment 15

[(not currently active) Ted Mielczarek]

Comment on attachment 8454931 [details] [diff] [review]
js.txt

Review of attachment 8454931 [details] [diff] [review]:
-----------------------------------------------------------------

I don't understand why this would fix anything. The code you're replacing is exactly the implementation of check_call:
http://svn.python.org/view/python/branches/release27-maint/Lib/subprocess.py?revision=87697&view=markup#l478

Comment 16

[Robert Longson [:longsonr]]

My build no longer hangs either with or without this patch so you're right this may well not have been the cause of the hangs.