1029954 - [Dialer][Call Screen][Conference] Icon size is larger than others and overlapped with 'Conference' when call hanging up

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Eric Chang [:ericcc] [:echang]]

Attachment: ConferenceIconOverlapped.png

### STR
1. Make call to flame A from phone B.
2. Make call to flame A from phone C.
3. Merge call on flame A.
4. Hang up call from phone either B or C.

### Actual
Icon size is larger than others and overlapped with 'Conference'
Check ConferenceIconOverlapped.png 

### Expected
Icon size the same as others and not overlapped

### Note
Design on Buri is different, not sure which one is for v2.0

### Version
Flame aurora v2.0 (either 2 sims or 1 sim)
Gaia      552ef3e7d00384e4f7ac43d8fab6b91c69cc26c1
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/e2b83f618868
BuildID   20140624160200
Version   32.0a2
ro.build.version.incremental=109
ro.build.date=Mon Jun 16 16:51:29 CST 2014
t2m.sw.version=B1TC00011220

Buri aurora v2.0
Gaia      552ef3e7d00384e4f7ac43d8fab6b91c69cc26c1
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/e2b83f618868
BuildID   20140624160200
Version   32.0a2
ro.build.version.incremental=324
ro.build.date=Thu Dec 19 14:04:55 CST 2013

Comment 1

[Eric Chang [:ericcc] [:echang]]

Attachment: Buri seems to be okay, but design is different

Comment 2

[Eric Chang [:ericcc] [:echang]]

Attachment: ConferenceIconBuri14.jpg

Comment 3

[Jason Smith [:jsmith]]

UX - Can you indicate if this is a blocker for the visual refresh?

Comment 4

[Stephany Wilkes]

Not great, but not blocking, and this should be an easy fix: the correct icon is shown in the third line but not at the top. Seems the correct asset just needs to be used. 

Would not block ship on this but would think this is low risk and could go up for approval?/+ to make 2.0 if possible.

Comment 5

[Anthony Ricaud (:rik)]

This is probably the same issue as bug 1029955.

Comment 6

[Paco Rampas [:paco]]

Attachment: patch in github

Comment 8

[Anthony Ricaud (:rik)]

Please ask for approval-2.0 once it has landed.

Comment 9

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Merged: f71bf6ee534275a44ae3e475e9e2a5dfeebbc0ae

Comment 10

[Paco Rampas [:paco]]

Comment on attachment 8449343 [details] [review]
patch in github

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): incorrect UX
[User impact] if declined: bad visualization
[Testing completed]: yes
[Risk to taking this patch] (and alternatives if risky): none
[String changes made]: none

Comment 11

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/65170a06f2e84a09d544a3d1ecc7b2fe43ac6b14

Comment 12

[Eric Chang [:ericcc] [:echang]]

Attachment: 1029954 .png

Verified okay, but the party who lefe looks like old design.
Gaia      aa4f795b81c6147d67c4f06009e166debcf8856e
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/0ec0b9ac39f0
BuildID   20140716160201
Version   32.0a2
ro.build.version.incremental=112
ro.build.date=Mon Jul 14 14:57:32 CST 2014

Comment 13

[Eric Chang [:ericcc] [:echang]]

20140624160200

Comment 14

[Elie]

Attachment: VIDEO0813_Compress.MP4

This issue has been successfully verified on Flame 2.0:
Gaia-Rev        3aa0797c111a40e36f722722309668de3d469181
Gecko-Rev       93efc8b4155f0a4a50eaad19acbb95ec24139e63
Build-ID        20141204050313
Version         32.0
Device-Name     jrdhz72_w_ff
FW-Release      4.4.2

This issue has been successfully verified on Flame 2.1:
Gaia-Rev        dbaf3e31c9ba9c3436e074381744f2971e15c7bf
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/ebce587d2194
Build-ID        20141203001205
Version         34.0
Device-Name     flame
FW-Release      4.4.2