rewrite settings build script in javascript

RESOLVED FIXED

Status

Firefox OS
Gaia::Build
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: yurenju, Assigned: yurenju)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

since we found a way to require r.js in gaia build environement, we can remove Makefile in settings directory and rewrite the code in javascirpt.
Assignee: nobody → yurenju.mozilla
Status: NEW → ASSIGNED
Created attachment 8445786 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/20970

Alex, could you review this pull request? and I also found we can't get STDOUT from nsIProccess, do you have any idea for that?
Attachment #8445786 - Flags: review?(poirot.alex)
Depends on: 1028816
Comment on attachment 8445786 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/20970

Looks good, thanks!
Can you f?/r? a settings peer so that they know about this ?
Attachment #8445786 - Flags: review?(poirot.alex) → review+
(In reply to Yuren [:yurenju] from comment #1)
> Created attachment 8445786 [details] [review]
> github PR: https://github.com/mozilla-b2g/gaia/pull/20970
> 
> Alex, could you review this pull request? and I also found we can't get
> STDOUT from nsIProccess, do you have any idea for that?

Yes... nsIProcess is extremelly old and limited.
We now have some new ways to run processes, like child_process (which is supposed to have same API than node):
  http://mxr.mozilla.org/mozilla-central/source/addon-sdk/source/lib/sdk/system/child_process.js
Or subprocess (child_process is based on it):
  http://mxr.mozilla.org/mozilla-central/source/addon-sdk/source/lib/sdk/system/child_process/subprocess.js
These new APIs allow fine control on std IOs!
follow up bug is filed, bug 1031123
Comment on attachment 8445786 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/20970

offline discussed with Arthur, set review? to him.
Attachment #8445786 - Flags: review?(arthur.chen)
Comment on attachment 8445786 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/20970

Looks good to me, thank you!
Attachment #8445786 - Flags: review?(arthur.chen) → review+
merged.

https://github.com/mozilla-b2g/gaia/commit/d6976b6954437bd317dd9e36fab27e0f86213d2f
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.