1029966 - rewrite settings build script in javascript

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

since we found a way to require r.js in gaia build environement, we can remove Makefile in settings directory and rewrite the code in javascirpt.

Comment 1

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Attachment: github PR: https://github.com/mozilla-b2g/gaia/pull/20970

Alex, could you review this pull request? and I also found we can't get STDOUT from nsIProccess, do you have any idea for that?

Comment 2

[Alexandre Poirot [:ochameau]]

Comment on attachment 8445786 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/20970

Looks good, thanks!
Can you f?/r? a settings peer so that they know about this ?

Comment 3

[Alexandre Poirot [:ochameau]]

(In reply to Yuren [:yurenju] from comment #1)
> Created attachment 8445786 [details] [review]
> github PR: https://github.com/mozilla-b2g/gaia/pull/20970
> 
> Alex, could you review this pull request? and I also found we can't get
> STDOUT from nsIProccess, do you have any idea for that?

Yes... nsIProcess is extremelly old and limited.
We now have some new ways to run processes, like child_process (which is supposed to have same API than node):
  http://mxr.mozilla.org/mozilla-central/source/addon-sdk/source/lib/sdk/system/child_process.js
Or subprocess (child_process is based on it):
  http://mxr.mozilla.org/mozilla-central/source/addon-sdk/source/lib/sdk/system/child_process/subprocess.js
These new APIs allow fine control on std IOs!

Comment 4

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

follow up bug is filed, bug 1031123

Comment 5

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8445786 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/20970

offline discussed with Arthur, set review? to him.

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8445786 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/20970

Looks good to me, thank you!

Comment 7

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

rebase to master and push try server again:

https://tbpl.mozilla.org/?rev=314f9585446fb7b90c150703c57fddbb41d732d9&tree=Gaia-Try

Comment 8

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

merged.

https://github.com/mozilla-b2g/gaia/commit/d6976b6954437bd317dd9e36fab27e0f86213d2f

Comment 9

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

b2g-inbound:

https://tbpl.mozilla.org/?tree=B2g-Inbound&rev=73730a9f374d