Closed
Bug 1029991
Opened 11 years ago
Closed 11 years ago
"bug_comments" hook should run after comment tags are pre-loaded
Categories
(bugzilla.mozilla.org :: General, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: glob, Assigned: glob)
Details
Attachments
(1 file)
|
787 bytes,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
the bmo custom hook "bug_comments" currently runs before comment tags are preloaded.
as our code which hides comments tagged as 'deleted' loads a comment's tags, this results in an individual query for each comment to fetch the tags.
stack trace of the query in question:
"Bugzilla/Comment.pm:205",
"BMO/Extension.pm:1417",
"extensions/BMO/Extension.pm:1427",
"Bugzilla/Hook.pm:33",
"Bugzilla/Bug.pm:3491",
"Bugzilla/Bug.pm:515",
"show_bug.cgi:93"
Attachment #8445700 -
Flags: review?(dkl)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8445700 [details] [diff] [review]
1029991_1.patch
Review of attachment 8445700 [details] [diff] [review]:
-----------------------------------------------------------------
r=dkl
Attachment #8445700 -
Flags: review?(dkl) → review+
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
b8bd592..6844714 master -> master
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•