1030014 - Unable to compile deterministic js shells

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: log

I'm unable to compile deterministic debug ARM-simulator js shells.

Steps:
1. In js/src, run autoconf213
2. Create and cd into objdir
3. Run: LD=ld CROSS_COMPILE=1 CC="clang -Qunused-arguments -msse2 -mfpmath=sse -arch i386" RANLIB=ranlib CXX="clang++ -Qunused-arguments -msse2 -mfpmath=sse -arch i386" AS=$CC AR=ar STRIP="strip -x -S" HOST_CC="clang -Qunused-arguments -msse2 -mfpmath=sse" HOST_CXX="clang++ -Qunused-arguments -msse2 -mfpmath=sse" sh /Users/skywalker/trees/mozilla-central/js/src/configure --target=i386-apple-darwin9.2.0 --enable-macos-target=10.5 --enable-optimize --disable-debug --enable-profiling --enable-gczeal --enable-debug-symbols --disable-tests --enable-more-deterministic --with-ccache --disable-threadsafe --enable-arm-simulator
4. Run: make -j1

autoBisect shows this is probably related to the following changeset:

The first bad revision is:
changeset:   https://hg.mozilla.org/mozilla-central/rev/4a04ca5ed7d3
user:        Jason Orendorff
date:        Mon Jun 23 10:57:03 2014 -0500
summary:     Bug 645417, part 26 - Update jsid sorting for JS_MORE_DETERMINISTIC. r=luke.

jorendorff, is bug 645417 a likely regressor?

Comment 1

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

That seems like the wrong bug number in the commit message - maybe it's bug 645416?

Also, this build failure seems to also happen on Linux. Just compile with your usual 32-bit compilation parameters and --enable-debug --enable-arm-simulator --enable-more-deterministic.

Comment 2

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

> --target=i386-apple-darwin9.2.0 --enable-macos-target=10.5 --enable-optimize
> --disable-debug --enable-profiling --enable-gczeal --enable-debug-symbols

This should be --enable-debug --disable-optimize.

Comment 3

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

fwiw I'm also unable to compile non-threadsafe shells (not ARM simulator).

Comment 4

[Jason Orendorff [:jorendorff]]

Attachment: bug-1030014-v1.patch

Two bugs:

- one in symbol code (mine, introduced by renaming something)

- one in gc code (lars's, therefore he gets the review)

Comment 5

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Comment on attachment 8446817 [details] [diff] [review]
bug-1030014-v1.patch

This patch fixes my build failures for deterministic and/or threadsafe, and also ARM simulator builds after some quick testing.

Comment 6

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8446817 [details] [diff] [review]
bug-1030014-v1.patch

Review of attachment 8446817 [details] [diff] [review]:
-----------------------------------------------------------------

r=me for the UniqueSymbol thing

Comment 7

[Jason Orendorff [:jorendorff]]

jandem already fixed the other bit, so I'm ready to land just the UniqueSymbol thing, as soon as the tree opens.

Comment 8

[Jason Orendorff [:jorendorff]]

Attachment: bug-1030014-more-deterministic-v2.patch

Carrying forward sfink's review.

Comment 9

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/406904577dfc

Comment 10

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Borked commit message for the first landing, backed out, relanded.

https://hg.mozilla.org/integration/mozilla-inbound/rev/d4500ef33c12
https://hg.mozilla.org/integration/mozilla-inbound/rev/d0a80ba46f6f

Comment 11

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/d0a80ba46f6f