1030029 - Some zipped plugins (e.g. GitHub) fail to install because nsIZipReader extracts files read-only

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Robert Utasi [:hunboy]]

During installing cz-plugin-***.zip it fails with this error message:

An error occurred extracting the compressed source: [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsILocalFile.remove]" nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)" location: "JS frame :: chrome://chatzilla/content/static.js :: cli_installPlugin :: line 3391" data: no]

Comment 1

[Robert Utasi [:hunboy]]

mozilla central
2012.12.04 last good
2012.12.05 first fail

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5c6b71348e20&tochange=0947e291578a

the plausible blocker bug is Bug 369108

Comment 2

[Robert Utasi [:hunboy]]

the dead point is on the trunk:
http://hg.mozilla.org/chatzilla/file/bc1416776f05/xul/content/static.js#l3369

Comment 3

[Robert Utasi [:hunboy]]

when I comment out the

initJSFile.remove(false);

line, it works.
the install-plugin.temp file is read only. This is the problem.

Comment 4

[Robert Utasi [:hunboy]]

CC-ed Brian R. Bondy

The nsIZipReader extracts the files in readonly mode permanently based on Bug 369108, so unzips the all of plugin files as readonly.

I've checked the zipReader's inteface and no way to set up filemode at zipReader.extract()

void extract(in AUTF8String zipEntry, in nsIFile outFile)

this is a permanent problem for update/delete plugin as well.

Comment 5

[Brian R. Bondy [:bbondy]]

So I think we should either not set the permissions mode when extracting to avoid getting the read only in the first place, or we could update nsIFile's implementation on Windows to remove the read only bit before removing if it fails.

Comment 6

[James Ross]

It's not clear where the original report here was getting the zip, but I know GitHub's zips are a problem:

[22:14:20]	[INFO]	Downloading plugin from 'https://github.com/twpol/cz-plugin-network-trace/archive/master.zip'…
[22:14:21]	[INFO]	Installing from 'C:\Users\James\AppData\Roaming\ChatZilla\Profiles\0n2xrybw.default\chatzilla\plugin-install.temp.zip' to 'E:\Documents\Coding\ChatZilla\Scripts'…
	[ERROR]	An error occurred extracting the compressed source: [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsILocalFile.remove]"  nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)"  location: "JS frame :: chrome://chatzilla/content/static.js :: cli_installPlugin :: line 3329"  data: no]

Comment 8

[James Ross]

Attachment: Set permissions to 0666 for every extracted file

Comment 9

[:Gijs (he/him)]

Comment on attachment 8716805 [details] [diff] [review]
Set permissions to 0666 for every extracted file

r=me assuming this was tested on Windows, and throws just as or less often as/than the .remove() call (ie what if we don't have the rights to set the permissions to 0666 ? Presumably the setter will throw, but then, the .remove() call would also have thrown...)

Comment 10

[James Ross]

This was tested on Windows - the SetPermission implementation looks for any-read and any-write, of which only any-write is implemented (as setting and unsetting the read-only flag). Other platforms should work per Unix.

http://hg.mozilla.org/chatzilla/file/ecf32181bbab

Comment 11

[James Ross]

http://hg.mozilla.org/chatzilla/rev/ecf32181bbab