Closed
Bug 1030116
Opened 11 years ago
Closed 11 years ago
Fix test_pop3MoveFilter2.js to work with maildir.
Categories
(MailNews Core :: Testing Infrastructure, defect)
MailNews Core
Testing Infrastructure
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 33.0
People
(Reporter: sshagarwal, Assigned: sshagarwal)
References
Details
Attachments
(1 file, 2 obsolete files)
4.27 KB,
patch
|
sshagarwal
:
review+
|
Details | Diff | Splinter Review |
Modify test_pop3MoveFilter2.js to pass with both maildir and mbox mailbox storage formats.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #8445840 -
Flags: review?(kent)
Comment 2•11 years ago
|
||
Comment on attachment 8445840 [details] [diff] [review]
Patch v1
Review of attachment 8445840 [details] [diff] [review]:
-----------------------------------------------------------------
r=me with renaming of that function.
::: mailnews/local/test/unit/test_pop3MoveFilter2.js
@@ +93,5 @@
> }
> return count;
> }
>
> +function run_all_tests(storeID)
I found myself confused by the name of this, so let's use a different name. This method does not "run all tests", let's use setup_store instead.
Attachment #8445840 -
Flags: review?(kent) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Thanks.
Assignee: nobody → syshagarwal
Attachment #8445840 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8446058 -
Flags: review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 4•11 years ago
|
||
Attachment #8446058 -
Attachment is obsolete: true
Attachment #8446062 -
Flags: review+
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 33.0
You need to log in
before you can comment on or make changes to this bug.
Description
•