Closed Bug 1030116 Opened 11 years ago Closed 11 years ago

Fix test_pop3MoveFilter2.js to work with maildir.

Categories

(MailNews Core :: Testing Infrastructure, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 33.0

People

(Reporter: sshagarwal, Assigned: sshagarwal)

References

Details

Attachments

(1 file, 2 obsolete files)

Modify test_pop3MoveFilter2.js to pass with both maildir and mbox mailbox storage formats.
Blocks: 1011399
Depends on: 827048
Attached patch Patch v1 (obsolete) — Splinter Review
Attachment #8445840 - Flags: review?(kent)
Comment on attachment 8445840 [details] [diff] [review] Patch v1 Review of attachment 8445840 [details] [diff] [review]: ----------------------------------------------------------------- r=me with renaming of that function. ::: mailnews/local/test/unit/test_pop3MoveFilter2.js @@ +93,5 @@ > } > return count; > } > > +function run_all_tests(storeID) I found myself confused by the name of this, so let's use a different name. This method does not "run all tests", let's use setup_store instead.
Attachment #8445840 - Flags: review?(kent) → review+
Attached patch Patch for check-in (obsolete) — Splinter Review
Thanks.
Assignee: nobody → syshagarwal
Attachment #8445840 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8446058 - Flags: review+
Keywords: checkin-needed
Attachment #8446058 - Attachment is obsolete: true
Attachment #8446062 - Flags: review+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 33.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: