1030159 - Make image deferring work with screenshots

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: Consumer Pages, defect, P2)

Description

[Wil Clouser [:clouserw]]

Using Yogafire's screenshot selector in fireplace will let us drop flipsnap and get deferred images as well.

Comment 1

[Wil Clouser [:clouserw]]

Andy suggests we make sure this works on Android as there has been some trouble in the past.

Comment 2

[Mathieu Pillard [:mat]]

Re-purposing this bug per the discussion we had on IRC: the real goal is to a) make sure our screenshot selector works with image deferring and b) fix the scrolling bugs we had with it (bug 972425, bug 1020670).

Getting rid of flipsnap and using yogafire's screenshot code is one solution, but we would lose swiping (both between thumbnails and screenshots themselves) which is kinda sad. I'm going to try alternatives like updating flipsnap first.

Comment 3

[Mathieu Pillard [:mat]]

Updated flipsnap in https://github.com/mozilla/fireplace/commit/22231b595b6b571e55cdf3b2573cb96830252389

Comment 4

[Mathieu Pillard [:mat]]

PR to make flipsnap work with image deferring: https://github.com/mozilla/fireplace/pull/526

Comment 6

[Mathieu Pillard [:mat]]

We closed the PR because I didn't update it to work with the feed changes. If anyone wants to pick it up before I get the motivation to do so, please do! I've left the branch opened, and the description of the PR should mention what is left to do.