Closed Bug 1030159 Opened 10 years ago Closed 8 years ago

Make image deferring work with screenshots

Categories

(Marketplace Graveyard :: Consumer Pages, defect, P2)

Product:
Marketplace Graveyard
Component:
Consumer Pages
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: clouserw, Unassigned)

References

Details

(Keywords: perf, Whiteboard: [marketplace-transition]) 

Using Yogafire's screenshot selector in fireplace will let us drop flipsnap and get deferred images as well.
Andy suggests we make sure this works on Android as there has been some trouble in the past.
Priority: -- → P2
Assignee: nobody → mpillard
Re-purposing this bug per the discussion we had on IRC: the real goal is to a) make sure our screenshot selector works with image deferring and b) fix the scrolling bugs we had with it (bug 972425, bug 1020670).

Getting rid of flipsnap and using yogafire's screenshot code is one solution, but we would lose swiping (both between thumbnails and screenshots themselves) which is kinda sad. I'm going to try alternatives like updating flipsnap first.
Summary: Use yogafire screenshot selector in fireplace → Make image deferring work with screenshots
PR to make flipsnap work with image deferring: https://github.com/mozilla/fireplace/pull/526
Status: NEW → ASSIGNED
We closed the PR because I didn't update it to work with the feed changes. If anyone wants to pick it up before I get the motivation to do so, please do! I've left the branch opened, and the description of the PR should mention what is left to do.
Assignee: mpillard → nobody
Status: ASSIGNED → NEW
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
Whiteboard: [marketplace-transition]
You need to log in before you can comment on or make changes to this bug.