New context menu items

VERIFIED FIXED in mozilla1.0

Status

SeaMonkey
UI Design
P2
enhancement
VERIFIED FIXED
17 years ago
4 years ago

People

(Reporter: Peter Trudelle, Assigned: Joe Hewitt (gone))

Tracking

Trunk
mozilla1.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

17 years ago
This is a meta bug representing the planning and design work for this feature,
the actual work will be represented by dependency bugs for the subtasks. If you
want to discuss any of this at length, please do so in the appropriate newsgroup
(UI,browser,perf,...), and just add a link to the discussion in this bug report.
 Here is our current plan for this:
--------------------------
New Context Menu Options

1) Set Image As Wallpaper
(Windows only)
- Ability to obtain in-memory bitmap representation for a given image in a
document - 3 days (conservative)
- Write this representation to disk in the correct location, as "Brandname
Wallpaper" -  2 days (conservative)
- menu item UI - 1 day.

2) Save Page as Text
- Develop scheme for formatting HTML input into sensible text output. At 
simplest, this could just be outputting non tag elements to a file. If so,
swag - 3 days for back end, 1 day for menu item. Alternative option could 
leverage mail code for converting formatted mail into plain text to do the same
task, assuming their system uses a clever scheme. 5 days for this route,  1 day
for menu item. This feature seems less useful to me personally, as if  you want
the text of a page, you can always select the content blocks
visually and paste into an editor. Better copy and paste handling would tend  to
make those types of operations more successful.

3) Save page with Images - this is the useful one. Involves:
- creating a folder on disk under where the file was saved for page objects,
with name "filenamesavedto files" - 1 day
- search through the document for objects to save, as a base line this would 
include - images, included javascript files (imported via script tag), and
included stylesheets (imported via link tag). - 3 days
- initiate downloads of those individual items.  - 4 days
Total - 7 days including menu item. (conservative)

4) Send Page, Edit Page - one day inclusive, just involves adding UI

Before we add anything to the context menus, we should do some cleaning of 
what's in there already. It is currently heavy in many cases, and the code
behind it is confusing. Blake has volunteered to help with this in 0.9.5
---------------------
This plan needs review and r= approval.
bug 75338 is the context menu UI uber bug.
Depends on: 75338
(Reporter)

Updated

17 years ago
Blocks: 102472

Comment 2

17 years ago
r=law for the plan and design

I've posted some comments on design alternatives to n.p.m.browser.
(Reporter)

Comment 3

17 years ago
Added separate plan page for this at
http://mozilla.org/xpapps/MachVPlan/Context_Menu_Options.html

Forgot to list suggested requirements:
    * Ability to set image as wallpaper
    * Ability to save a page as text only or complete with images
    * Ability to send page
    * Ability to edit page in composer
    * Investigate/spec out alternative ways to expose context menu functionality

P2/096
Priority: -- → P2
Target Milestone: --- → mozilla0.9.6
You may want to collect the number of other bugs on these proposed features
which are lying around Bugzilla, and which have much useful discussion in them.
To start you off, the Set As Wallpaper bug is bug 41526.

Gerv
How was the decision within Netscape made to have these items in the context
menu (as opposed to anywhere else) for Mach V? Only one of the five (Set As
Wallpaper) is context-sensitive.

Gerv
(Reporter)

Comment 6

17 years ago
Thanks Gerv, I did see that, but wasn't sure if it was a good idea to just
reassign it and make it a dependency. As for a 'decision', there has been none
so far, only some suggested requirements from marketing, and an engineering
plan-in-progress. I put all this out onto mozilla.org/Bugzilla so we could get
the plan right. Thanks for helping!  We're already discussing your last comment
in n.p.m.browser...

Updated

17 years ago
Depends on: 41526

Updated

17 years ago
No longer depends on: 41526

Comment 7

17 years ago
Also see bug 103591 "Improved Image Managent".

Updated

17 years ago
No longer depends on: 75338
Status: NEW → ASSIGNED
Depends on: 11632, 41526

Comment 8

17 years ago
I think this bug should be wontfixed.

- Saving a page as text or with images should be options in the file picker 
dialog or in the File menu, not in the context menus.  

- "Edit page" is not a common operation.

- "Send page" will encourage users include entire web pages in their e-mails 
rather sending a link, which is annoying because the page might have updated, 
and because the recipient might not using a mail reader that supports every 
element in the web page (html, javascript, pngs).

- UI for setting wallpapers should be provided by the OS, not web browsers.  If 
you include the option in the browser, you'll have to choose between 
overwriting "Mozilla wallpaper.bmp" each time "set as wallpaper" is chosen, or 
creating a new file each time, neither of which is what the user wants.
Depends on: 26939
(Reporter)

Comment 9

17 years ago
Please don't fixate on the summary, that was just how the feature request came
to us, and is not necessarily how these commands will be exposed.  In any case,
discussion of how to do this belongs in the newsgroups, not in this tracking bug. 
Created attachment 55041 [details] [diff] [review]
"Edit Page/Link", "Send Page/Link" implementation (not quite a real apply-able patch)

Comment 11

17 years ago
Comment on attachment 55041 [details] [diff] [review]
"Edit Page/Link", "Send Page/Link" implementation (not quite a real apply-able patch)

r=pchen assuming Ben can get a version that CAN be applied ;-)
Attachment #55041 - Flags: review+

Comment 12

17 years ago
sr=hyatt
This patch checked in. 

Comment 14

17 years ago
there's now a crash on mail startup: bug 107334

Comment 15

17 years ago
This patch includes 3 ^M in editor/ui/composer/content/editorNavigatorOverlay.xul

Comment 16

17 years ago
>  2) Save Page as Text

 The conversion functionality already exist in the nsPlainTextSerializer in
layout (or is it content?) It is used by mail but also by copy/paste (try to
select a full page, copy and paste into your favorite text editor (emacs)). Its
functionality is much better than NS4.x' but it's not a full layout engine which
would be necessary to make "perfect" text output.

Akkana among others would know how to use it. I only know how it works. :-)

Comment 18

17 years ago
nsIDocumentEncoder (with a mime type of text/plain) is the currently recommended
API for getting at the plaintext serializer.  But there are plans in the works
to integrate this with other APIs; JST says there's a standard document-saving
interface being considered by the W3C, and we want to try to track that if we
can get a preview of it.
Depends on: 107568
No longer depends on: 107568

Comment 19

17 years ago
context menu items do not work in composer. Please see bug 108084

Is 108084 a DUP of this bug?

Updated

17 years ago
Blocks: 108084
also as per n.p.m.general  - block images from this server are gone from the
browser context menu.

looks like blocked images had returned a few days later between 11-04 and this
comment 11-11 builds from hidden context menu problems.

Updated

17 years ago
Blocks: 108339

Updated

17 years ago
Depends on: 75338
Target Milestone: mozilla0.9.6 → mozilla0.9.7

Comment 22

17 years ago
2 and 3 (save as text, save with images/etc) should simply be added to the
current  save dialog, with "Save entire page" the default, so it's exposed more.
"Save HTML only" and "Save as plain text" would be selectable from a dropdown. I
think this is in line with IE.
sending to joe, as he has the remainder of this work.
Assignee: ben → hewitt
Status: ASSIGNED → NEW
Target Milestone: mozilla0.9.7 → ---

Comment 24

17 years ago
> 1) Set Image As Wallpaper

How about puting this in page info->images? Page info has a lot of potential but
doesn't do or show anything useful right now. I can't even block/unblock/save
images from there.

> 4) Send Page, Edit Page

These are not context operations.

Why isn't this being integrated with the current work at
http://mozilla.org/projects/ui/menus/shortcut/ rather then being tacked on the
the awful current menus.

Comment 25

17 years ago
please pay attention to comment 9.
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.0.1

Updated

17 years ago
No longer depends on: 75338

Comment 26

17 years ago
This bug is targetted for M101. Should we remove it from blocking Bug 102472,
since its current target is outside the dev window for the next release?
Attachment #55041 - Flags: needs-work+
(Reporter)

Comment 27

17 years ago
nsbeta1+, Moz1.0
Keywords: nsbeta1+
Target Milestone: mozilla1.0.1 → mozilla1.0
(Assignee)

Comment 28

17 years ago
all of these context menus are in already
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
right. rs vrfy --see specific bugs in dep tree.
Status: RESOLVED → VERIFIED

Updated

17 years ago
No longer depends on: 75338
Product: Core → Mozilla Application Suite

Updated

10 years ago
Component: XP Apps: GUI Features → UI Design
You need to log in before you can comment on or make changes to this bug.