NullPointerException when accessing ActionBar

VERIFIED FIXED in Firefox 31

Status

()

defect
--
critical
VERIFIED FIXED
5 years ago
3 years ago

People

(Reporter: blassey, Assigned: blassey)

Tracking

({crash})

Trunk
Firefox 33
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox31+ verified, firefox32+ verified, firefox33 verified, fennec31+)

Details

Attachments

(2 attachments)

seeing this in our beta crashes in google play. According to the docs [1], this method can return null, but we use it directly in our code [2].


[1] http://developer.android.com/reference/android/app/Activity.html#getActionBar%28%29
[2] https://mxr.mozilla.org/mozilla-beta/source/mobile/android/base/preferences/GeckoPreferences.java#170
We'll need a different patch for beta. I haven't looked at aurora.
Assignee: nobody → blassey.bugs
Attachment #8446527 - Flags: review?(rnewman)
Attachment #8446537 - Flags: review?(rnewman)
Severity: normal → critical
Keywords: crash
OS: Mac OS X → Android
Hardware: x86 → ARM
Comment on attachment 8446527 [details] [diff] [review]
getActionBar.patch

Review of attachment 8446527 [details] [diff] [review]:
-----------------------------------------------------------------

Nit: braces around conditionals.
Attachment #8446527 - Flags: review?(rnewman) → review+
Status: NEW → ASSIGNED
Hardware: ARM → All
Summary: NullPointerException when getting action bar → NullPointerException when accessing ActionBar
Component: General → Settings and Preferences
Comment on attachment 8446537 [details] [diff] [review]
getActionBar_beta.patch

Review of attachment 8446537 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/preferences/GeckoPreferences.java
@@ +1,2 @@
>  /* -*- Mode: Java; c-basic-offset: 4; tab-width: 4; indent-tabs-mode: nil; -*-
> + Source Code Form is subject to the terms of the Mozilla Public

Looks like an accidental deletion here...
Attachment #8446537 - Flags: review?(rnewman) → review+
tracking-fennec: ? → 31+
https://hg.mozilla.org/mozilla-central/rev/d33ca5cb5df3
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
Depends on: 1033013
Comment on attachment 8446537 [details] [diff] [review]
getActionBar_beta.patch

Review of attachment 8446537 [details] [diff] [review]:
-----------------------------------------------------------------

Top crash in the android play store reporting (before our crash reporting gets hooked up)
Attachment #8446537 - Flags: approval-mozilla-beta?
Attachment #8446537 - Flags: approval-mozilla-aurora?
Brad, could you fill the uplift request form? we need it before approving any patch. Thanks
Flags: needinfo?(blassey.bugs)
(In reply to Sylvestre Ledru [:sylvestre] from comment #9)
> Brad, could you fill the uplift request form? we need it before approving
> any patch. Thanks

The form is a guide, not a requirement. This is a null check to fix a top crash. I can approve it myself if you'd rather.
Flags: needinfo?(blassey.bugs)
Comment on attachment 8446537 [details] [diff] [review]
getActionBar_beta.patch

While it is generally beneficial to provide the information requested in a standard format, in this bug we do have all the information that we need to proceed. Approved for Beta and Aurora.
Attachment #8446537 - Flags: approval-mozilla-beta?
Attachment #8446537 - Flags: approval-mozilla-beta+
Attachment #8446537 - Flags: approval-mozilla-aurora?
Attachment #8446537 - Flags: approval-mozilla-aurora+
Verified as fixed in builds:
- 33.0a1 (2014-07-08);
- 32.0a2 (2014-07-08);
- 31 Beta 8;

Device: Google Nexus 10 (Android 4.4.2)
You need to log in before you can comment on or make changes to this bug.