1030738 - NullPointerException when accessing ActionBar

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Settings and Preferences, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

seeing this in our beta crashes in google play. According to the docs [1], this method can return null, but we use it directly in our code [2].


[1] http://developer.android.com/reference/android/app/Activity.html#getActionBar%28%29
[2] https://mxr.mozilla.org/mozilla-beta/source/mobile/android/base/preferences/GeckoPreferences.java#170

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: getActionBar.patch

We'll need a different patch for beta. I haven't looked at aurora.

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: getActionBar_beta.patch

Comment 3

[Richard Newman [:rnewman]]

Comment on attachment 8446527 [details] [diff] [review]
getActionBar.patch

Review of attachment 8446527 [details] [diff] [review]:
-----------------------------------------------------------------

Nit: braces around conditionals.

Comment 4

[Richard Newman [:rnewman]]

Comment on attachment 8446537 [details] [diff] [review]
getActionBar_beta.patch

Review of attachment 8446537 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/preferences/GeckoPreferences.java
@@ +1,2 @@
>  /* -*- Mode: Java; c-basic-offset: 4; tab-width: 4; indent-tabs-mode: nil; -*-
> + Source Code Form is subject to the terms of the Mozilla Public

Looks like an accidental deletion here...

Comment 5

[Ed Morley [:emorley]]

Push backed out for robocop-1 failures in testMasterPassword:
https://tbpl.mozilla.org/php/getParsedLog.php?id=42625238&tree=Fx-Team
https://tbpl.mozilla.org/php/getParsedLog.php?id=42624677&tree=Fx-Team

remote:   https://hg.mozilla.org/integration/fx-team/rev/18afe25e9df9
remote:   https://hg.mozilla.org/integration/fx-team/rev/cf633fa6f40b
remote:   https://hg.mozilla.org/integration/fx-team/rev/a033a0b332eb

Comment 6

[Richard Newman [:rnewman]]

Brad's original landing, for posterity: 

 https://hg.mozilla.org/integration/fx-team/rev/a9f445169eca

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d33ca5cb5df3

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 8446537 [details] [diff] [review]
getActionBar_beta.patch

Review of attachment 8446537 [details] [diff] [review]:
-----------------------------------------------------------------

Top crash in the android play store reporting (before our crash reporting gets hooked up)

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Brad, could you fill the uplift request form? we need it before approving any patch. Thanks

Comment 10

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Sylvestre Ledru [:sylvestre] from comment #9)
> Brad, could you fill the uplift request form? we need it before approving
> any patch. Thanks

The form is a guide, not a requirement. This is a null check to fix a top crash. I can approve it myself if you'd rather.

Comment 11

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8446537 [details] [diff] [review]
getActionBar_beta.patch

While it is generally beneficial to provide the information requested in a standard format, in this bug we do have all the information that we need to proceed. Approved for Beta and Aurora.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e9de3d835ecc
https://hg.mozilla.org/releases/mozilla-beta/rev/025d96672f65

Comment 13

[Flaviu Cos]

Verified as fixed in builds:
- 33.0a1 (2014-07-08);
- 32.0a2 (2014-07-08);
- 31 Beta 8;

Device: Google Nexus 10 (Android 4.4.2)