1030770 - Bookmarks panel is empty in guest mode

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Flaviu Cos]

Environment: 
Device: Google Nexus 10 (Android 4.4.2);
Build: Nightly 33.0a1 (2014-06-26);

Steps to reproduce:
1. Open fennec in guest mode;

Expected result:
Bookmarks panel is not available in guest mode.

Actual result:
Bookmarks panel is available in guest mode.

Comment 1

[Flaviu Cos]

Considering that the bookmarks are not present any more, and you can not add a bookmark in guest mode I think that the bookmarks panel is obsolete.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Ian - It appears that we no longer show the default bookmarks when entering guestmode. We also don't allow adding bookmarks. Should we remove the panel?

Comment 3

[Ian Barlow (:ibarlow)]

Hm, interesting. This seems like a question not just for bookmarks, but more for about:home in general! I wonder, is top sites useful in Guest Browsing? Is history? Is Reading List? 

To me the question is more like, what do we show Guest Browsing users on about:home? All panels? None of them? History only? A special Guest Browsing version of the about:home that tells you where you are, and how to exit?

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Ian Barlow (:ibarlow) from comment #3)
> Hm, interesting. This seems like a question not just for bookmarks, but more
> for about:home in general! I wonder, is top sites useful in Guest Browsing?
> Is history? Is Reading List? 

Top Sites will become useful even after a few minutes of browsing.

> To me the question is more like, what do we show Guest Browsing users on
> about:home? All panels? None of them? History only? A special Guest Browsing
> version of the about:home that tells you where you are, and how to exit?

Brilliant idea!

Comment 5

[Lucas Rocha (:lucasr)]

I'd go with the top sites, 'guest browsing' panel & history. Why top sites? Because of suggested sites :-)

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

There is nothing wrong with the bookmarks panel being available, but there is a problem with it being empty. Morphing this bug. Lucas will mark it up with an assignee and a regressing bug

Comment 7

[Lucas Rocha (:lucasr)]

rnewman, it seems the default bookmarks vanished from guest profiles because of bug 1016611.

Comment 8

[Aaron Train [:aaronmt]]

I don't think 32 is affected here then as the regressing bug only landed code on m-c.

Comment 9

[Ian Barlow (:ibarlow)]

(In reply to Brad Lassey [:blassey] (use needinfo?) from comment #6)
> There is nothing wrong with the bookmarks panel being available, but there
> is a problem with it being empty. Morphing this bug. Lucas will mark it up
> with an assignee and a regressing bug

Can we change the scope of this bug to be about making a more useful about:home experience for users of Guest Browsing? Figuring out how best to display the bookmarks panel feels like we're focusing too narrowly and missing a potentially more useful solution. 

For example, since we know that a lot of people who try Guest Browsing are getting stuck there and not leaving, I suggested in comment 3 that we might consider a single page version of about:home that tells you that you're currently using Guest Browsing, and provides a control to exit back to your normal browser.

Comment 10

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Ian Barlow (:ibarlow) from comment #9)
> (In reply to Brad Lassey [:blassey] (use needinfo?) from comment #6)
> > There is nothing wrong with the bookmarks panel being available, but there
> > is a problem with it being empty. Morphing this bug. Lucas will mark it up
> > with an assignee and a regressing bug
> 
> Can we change the scope of this bug to be about making a more useful
> about:home experience for users of Guest Browsing?
No, we discussed this in triage. Let's not scope-creep this regression fix. You have some interesting suggestions in comment 3 and comment 9. Please file separate bugs for them.

Comment 11

[Ian Barlow (:ibarlow)]

filed bug 1034214

Comment 12

[Richard Newman [:rnewman]]

Attachment: Initialize new guest mode profile directories. v1

Comment 13

[Richard Newman [:rnewman]]

Comment on attachment 8450413 [details] [diff] [review]
Initialize new guest mode profile directories. v1

This fixes the issue for me. Guest profile creation doesn't follow the ordinary profile creation flow, so I copypasta'd the little chunks that matter.

Note that I also start the FIRSTRUN UI telemetry session; let me know if it's not supposed to be live for Guest Mode sessions.

Comment 14

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8450413 [details] [diff] [review]
Initialize new guest mode profile directories. v1

Looks OK, but remove the FIRSTRUN telemetry. That should be reserved for the first non-guest profile only.

Comment 15

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/55d86232eec5

ni for uplift.

Comment 16

[Flaviu Cos]

(In reply to Aaron Train [:aaronmt] from comment #8)
> I don't think 32 is affected here then as the regressing bug only landed
> code on m-c.

The difference between the FF32 and FF33 is that in FF33 the bookmarks panel is empty and in FF32 the bookmarks panel contains the default bookmarks.
If the issue is that the bookmarks panel is empty then FF32 is unaffected;
If the issue is that the bookmarks panel is present then FF32 is affected.

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/55d86232eec5

Comment 18

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed in build:
Nightly 33.0a1 (2014-07-08);
Device:
Asus Transformer Pad TF300T (Android 4.2.1);