1030809 - [Calendar] Day view: time sidebar doesn't update when changing the locale

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Miller Medeiros [:millermedeiros]]

Attachment: day_view_sidebar_hour_l10n.png

steps to reproduce:

 1. open calendar app.
 2. go to day view.
 3. open settings app and switch language.
 4. go back to calendar app.

expected: all strings on the day view should be on the proper locale.

actual: event times (12 AM, 1 AM...) are not localized.

Comment 1

[Miller Medeiros [:millermedeiros]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21085/files

Comment 2

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8446829 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21085/files

LGTM!

Comment 3

[Dylan Oliver [:doliver]]

triage: assuming this is corrected by restarting the app, we generally don't block on locale changes since this is an infrequent use case. We should fix this but won't block or uplift.

Comment 5

[Miller Medeiros [:millermedeiros]]

landed on master: https://github.com/mozilla-b2g/gaia/commit/22846bf06d34bd42d124952402ab121e6ae05c27

Comment 6

[Edward Chen[:edchen]]

[Environment]
Gaia      3584b2723412ed3299c6761f465885d80651c87e
Gecko     https://hg.mozilla.org/mozilla-central/rev/e7806c9c83f3
BuildID   20140820160201
Version   34.0a1
ro.build.version.incremental=94
ro.build.date=Tue May 20 09:29:20 CST 2014


[Result]
PASS

Comment 7

[SandKing]

This issue has been verified successfully on Flame2.1
Verify video:"verify_1030809.mp4".

Flame2.1 build:
Gaia-Rev        db2e84860f5a7cc334464618c6ea9e92ff82e9dd
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/211eae88f119
Build-ID        20141126001202
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141126.033519
FW-Date         Wed Nov 26 03:35:30 EST 2014
Bootloader      L1TC00011880

Comment 8

[SandKing]

Attachment: Verified video: verified_1030809.mp4