Closed Bug 1031055 Opened 6 years ago Closed 6 years ago

Get rid of the Thebes backed gfxContexts in FrameLayerBuilder.cpp, and get rid of gfxASurface::DumpAsDataURL

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

Attachments

(1 file)

No description provided.
Attached patch patchSplinter Review
Assignee: nobody → jwatt
Attachment #8446843 - Flags: review?(matt.woodrow)
Ignore the gfxUtils.h change, that's in the wrong patch.
Comment on attachment 8446843 [details] [diff] [review]
patch

Review of attachment 8446843 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/FrameLayerBuilder.cpp
@@ +2343,5 @@
> +                                      itemVisibleRect.Size().ToIntSize(),
> +                                      SurfaceFormat::B8G8R8A8);
> +    tempDT->SetTransform(Matrix::Translation(-itemVisibleRect.TopLeft().x,
> +                                             -itemVisibleRect.TopLeft().y));
> +    context = new gfxContext(tempDT);

Set the transform on the gfxContext, the constructor clears any transforms on the DT.
Attachment #8446843 - Flags: review?(matt.woodrow) → review+
Blocks: 1031079
https://hg.mozilla.org/mozilla-central/rev/a9321d58fc98
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.