Remove the gfxContext(gfxASurface*) constructor and lots of code that's then dead as a result

RESOLVED FIXED in mozilla33

Status

()

RESOLVED FIXED
5 years ago
2 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

(Blocks: 1 bug)

Trunk
mozilla33
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(11 attachments)

2.08 KB, patch
bas.schouten
: review+
Details | Diff | Splinter Review
1.30 KB, patch
bas.schouten
: review+
Details | Diff | Splinter Review
1.38 KB, patch
bas.schouten
: review+
Details | Diff | Splinter Review
10.95 KB, patch
bas.schouten
: review+
Details | Diff | Splinter Review
6.10 KB, patch
bas.schouten
: review+
Details | Diff | Splinter Review
1.38 KB, patch
bas.schouten
: review+
Details | Diff | Splinter Review
13.50 KB, patch
bas.schouten
: review+
Details | Diff | Splinter Review
1.69 KB, patch
bas.schouten
: review+
Details | Diff | Splinter Review
7.88 KB, patch
bas.schouten
: review+
Details | Diff | Splinter Review
2.07 KB, patch
bas.schouten
: review+
Details | Diff | Splinter Review
63.35 KB, patch
bas.schouten
: review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
Until we completely get rid of Thebes backed gfxContexts we're going to need to maintain Thebes and Moz2D code paths in lots of places in the tree. Matt has started getting rid of these in bug 922942, but there are still 70+ locations where the gfxContext(gfxASurface*) constructor is being invoked in the tree:

https://mxr.mozilla.org/mozilla-central/search?string=gfxContext%28&filter=[sS]urface&tree=mozilla-central
(Assignee)

Updated

5 years ago
Depends on: 932198

Comment 1

5 years ago
Interested in helping here. I will work that list backwards.

Updated

5 years ago
Depends on: 933030
Depends on: 948221
Depends on: 965967
(Assignee)

Updated

5 years ago
Depends on: 988793
(Assignee)

Updated

5 years ago
Depends on: 934183
(Assignee)

Updated

5 years ago
Depends on: 988808
(Assignee)

Updated

5 years ago
Depends on: 988818
(Assignee)

Updated

5 years ago
Depends on: 988820
(Assignee)

Updated

5 years ago
Depends on: 988824
(Assignee)

Updated

5 years ago
Depends on: 991572
(Assignee)

Updated

5 years ago
Depends on: 991575
(Assignee)

Updated

5 years ago
Depends on: 991640
(Assignee)

Updated

5 years ago
Depends on: 998113
(Assignee)

Updated

5 years ago
Depends on: 1001687
(Assignee)

Updated

4 years ago
Depends on: 1018187
(Assignee)

Updated

4 years ago
Depends on: 1018196
(Assignee)

Updated

4 years ago
Depends on: 987194
(Assignee)

Updated

4 years ago
Depends on: 1019018
(Assignee)

Updated

4 years ago
Depends on: 1019492
(Assignee)

Updated

4 years ago
Depends on: 1019681
(Assignee)

Updated

4 years ago
Depends on: 1019690
(Assignee)

Updated

4 years ago
Depends on: 1019704
(Assignee)

Updated

4 years ago
Depends on: 1021973
(Assignee)

Updated

4 years ago
Depends on: 1022031
(Assignee)

Updated

4 years ago
Depends on: 1023522
(Assignee)

Updated

4 years ago
Depends on: 1025802
(Assignee)

Updated

4 years ago
Depends on: 1028786
(Assignee)

Updated

4 years ago
Depends on: 1028794
(Assignee)

Updated

4 years ago
Depends on: 1028825
(Assignee)

Updated

4 years ago
Depends on: 1029211
(Assignee)

Updated

4 years ago
Depends on: 1029455
(Assignee)

Updated

4 years ago
Depends on: 1031055
(Assignee)

Updated

4 years ago
Depends on: 1031079
(Assignee)

Updated

4 years ago
Depends on: 1033607
(Assignee)

Updated

4 years ago
Depends on: 1034399
(Assignee)

Updated

4 years ago
Depends on: 1034404
(Assignee)

Updated

4 years ago
Depends on: 1034528
(Assignee)

Updated

4 years ago
Assignee: nobody → jwatt
Keywords: leave-open
Summary: Eliminate all Thebes backed gfxContexts (i.e. consumers of the gfxContext(gfxASurface*) constructor) → Remove the gfxContext(gfxASurface*) constructor and lots of code that's then dead as a result
(Assignee)

Comment 3

4 years ago
Created attachment 8451048 [details] [diff] [review]
part 1 - Remove the gfxContext(gfxASurface*) constructor
Attachment #8451048 - Flags: review?(bas)
(Assignee)

Updated

4 years ago
Attachment #8451048 - Attachment description: part 3 - Remove the code for handling Thebes backed gfxContext in gfxDrawable.cpp → part 1 - Remove the gfxContext(gfxASurface*) constructor
(Assignee)

Comment 4

4 years ago
Created attachment 8451049 [details] [diff] [review]
part 2 - Remove the code for handling Thebes backed gfxContext in SVGEllipseElement.cpp
Attachment #8451049 - Flags: review?(bas)
(Assignee)

Comment 5

4 years ago
Created attachment 8451050 [details] [diff] [review]
part 3 - Remove the code for handling Thebes backed gfxContext in gfxDrawable.cpp
Attachment #8451050 - Flags: review?(bas)
(Assignee)

Comment 6

4 years ago
Created attachment 8451054 [details] [diff] [review]
part 4 - Remove the code for handling Thebes backed gfxContext in gfxFont
Attachment #8451054 - Flags: review?(bas)
(Assignee)

Comment 7

4 years ago
Created attachment 8451056 [details] [diff] [review]
part 5 - Remove code for handling Thebes backed gfxContext from various files under gfx/thebes/
Attachment #8451056 - Flags: review?(bas)
(Assignee)

Comment 8

4 years ago
Created attachment 8451057 [details] [diff] [review]
part 6 - Remove code for handling Thebes backed gfxContext in imgFrame.cpp
Attachment #8451057 - Flags: review?(bas)
(Assignee)

Comment 9

4 years ago
Created attachment 8451059 [details] [diff] [review]
part 7 - Remove code for handling Thebes backed gfxContext from various files under layout/base/
Attachment #8451059 - Flags: review?(bas)
(Assignee)

Comment 10

4 years ago
Created attachment 8451063 [details] [diff] [review]
part 8 - Remove code for handling Thebes backed gfxContext in nsNativeThemeCocoa.mm
Attachment #8451063 - Flags: review?(bas)
(Assignee)

Comment 11

4 years ago
Created attachment 8451068 [details] [diff] [review]
part 9 - Remove code for handling Thebes backed gfxContext from various files under gfx/layers/
Attachment #8451068 - Flags: review?(bas)
(Assignee)

Comment 12

4 years ago
Created attachment 8451069 [details] [diff] [review]
part 10 - Remove gfxContext::IsCairo()
Attachment #8451069 - Flags: review?(bas)
(Assignee)

Comment 13

4 years ago
Created attachment 8451089 [details] [diff] [review]
part 11 - Remove gfxContext::mCairo
Attachment #8451089 - Flags: review?(bas)
Attachment #8451048 - Flags: review?(bas) → review+
Attachment #8451049 - Flags: review?(bas) → review+
Attachment #8451050 - Flags: review?(bas) → review+
Attachment #8451054 - Flags: review?(bas) → review+
Attachment #8451056 - Flags: review?(bas) → review+
Attachment #8451057 - Flags: review?(bas) → review+
Comment on attachment 8451059 [details] [diff] [review]
part 7 - Remove code for handling Thebes backed gfxContext from various files under layout/base/

Review of attachment 8451059 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/nsCSSRendering.cpp
@@ +2542,1 @@
>    }

nit: I suspect this brace needs to go...
Attachment #8451059 - Flags: review?(bas) → review+
Attachment #8451063 - Flags: review?(bas) → review+
Attachment #8451068 - Flags: review?(bas) → review+
Attachment #8451069 - Flags: review?(bas) → review+
Comment on attachment 8451089 [details] [diff] [review]
part 11 - Remove gfxContext::mCairo

Review of attachment 8451089 [details] [diff] [review]:
-----------------------------------------------------------------

W00t!!!!

::: gfx/thebes/gfxContext.cpp
@@ -162,5 @@
> -
> -    if (dx && dy)
> -        cairo_surface_get_device_offset(s, dx, dy);
> -    return gfxASurface::Wrap(s);
> -  } else {

nit: This ought to need a closing brace removed somewhere... and some indentation change.
Attachment #8451089 - Flags: review?(bas) → review+
(Assignee)

Comment 17

4 years ago
Somehow the removal of CopySurface ended up in a later (not yet pushed) patch in my queue. Pushed separately:

https://hg.mozilla.org/integration/mozilla-inbound/rev/e13ecd9e3def
(Assignee)

Updated

4 years ago
No longer depends on: 934183
(Assignee)

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Keywords: leave-open
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
(Assignee)

Comment 20

4 years ago
Thanks. :)
You need to log in before you can comment on or make changes to this bug.