1031155 - [tarako][SMS]Can't add the attachment of video from camera into MMS when automatic recording to stop

Status: RESOLVED DUPLICATE of bug 987546

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Chaochao Huang]

STR：
1、Open the SMS app.
2、Click on the iconAdd icon.
3、Click on the attachButton button.
4、Click on the camera button.
5、Click on the video button.
6、Click on the begin button and automatic record to stop.
7、Click on the ok button, then click on the select button.

OBSERVED:
8. POP up a dialog "The file you have selected is too large".

EXPECTED:
9.The attachment of video from camera can be added into MMS normally.

Comment 1

[Xiaohong.Fan]

There is a size limitation in SMS,
when the camera begins to record videos,
the size limitation will be sent to framework function MPEG4Writer::exceedsFileSizeLimit(),
if the size reaches  (95 * mMaxFileSizeLimitBytes) / 100),
it will make a callback to tell gaia to stop recording ,
during the callback, 
the camera is still recording videos and the size is probably out of mMaxFileSizeLimitBytes.
It may cause the problem.

Comment 2

[Chaochao Huang]

Now there are two kinds of methods to solve the problem.
1、Decrease the size of activityData.maxFileSizeBytes in sms.

if (Settings.mmsSizeLimitation) {
        //Decrease mms message size to 280K for Bug 325917.
-        activityData.maxFileSizeBytes = Settings.mmsSizeLimitation;
+        activityData.maxFileSizeBytes = Settings.mmsSizeLimitation - Settings.mmsSizeLimitationDecrease;
      }

2、Decrease the size of exceedsFileSizeLimit in framework function.

bool MPEG4Writer::exceedsFileSizeLimit() {
    int64_t nTotalBytesEstimate = static_cast<int64_t>(mEstimatedMoovBoxSize);
    for (List<Track *>::iterator it = mTracks.begin();
         it != mTracks.end(); ++it) {
        nTotalBytesEstimate += (*it)->getEstimatedTrackSizeBytes();
    }

    // Be conservative in the estimate: do not exceed 95% of
    // the target file limit. For small target file size limit, though,
    // this will not help.
-   return (nTotalBytesEstimate >= (95 * mMaxFileSizeLimitBytes) / 100);
+   return (nTotalBytesEstimate >= (85 * mMaxFileSizeLimitBytes) / 100);
}

Do you think which one is more reasonable？ And if you have more reasonable method, tell me. 
Thank you very much!

Comment 3

[Peipei Cheng (needinfo if you need my action)]

I tried 10 times on latest mozilla pvt build. but didn't see this problem. Could you please let us know the reproduce rate for this problem?

Comment 4

[Chaochao Huang]

(In reply to pcheng from comment #3)
> I tried 10 times on latest mozilla pvt build. but didn't see this problem.
> Could you please let us know the reproduce rate for this problem?

Before begin recording, wait for 10 seconds.The reproduce rate is 1/5.

Comment 5

[Peipei Cheng (needinfo if you need my action)]

I also noticed that after video stopped recording and was attached to mms, the size of video is around 284kb ~ 288kb but never exceed 300kb. 
It seems to me that it could happen when device memory is low and it takes longer time to tell gaia to stop recording when it almost reach the limit. But I tried several times and could not reproduce.



Test build
│ Gaia      925100f6f7b8dbe158d5921d01404ea823f4e64e                         │
│ Gecko                                                                      │
│ https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/78268d05d2af       │
│ BuildID   20140626164001                                                   │
│ Version   28.1                                                             │
│ ro.build.version.incremental=eng.cltbld.20140626.200526

Comment 6

[Peipei Cheng (needinfo if you need my action)]

And the solution in comment 2 only makes it a little better. In some extreme case, it still could happen.

Comment 7

[Chaochao Huang]

Yes. The decreased value is only from the experience.

Comment 8

[Julien Wajsberg [:julienw]]

(In reply to Xiaohong.Fan from comment #1)
> There is a size limitation in SMS,
> when the camera begins to record videos,
> the size limitation will be sent to framework function
> MPEG4Writer::exceedsFileSizeLimit(),
> if the size reaches  (95 * mMaxFileSizeLimitBytes) / 100),
> it will make a callback to tell gaia to stop recording ,
> during the callback, 
> the camera is still recording videos and the size is probably out of
> mMaxFileSizeLimitBytes.
> It may cause the problem.

Why couldn't the Writer stop writing at that moment?

Comment 9

[Evelyn Hung]

(In reply to Julien Wajsberg [:julienw] from comment #8)
> (In reply to Xiaohong.Fan from comment #1)
> > There is a size limitation in SMS,
> > when the camera begins to record videos,
> > the size limitation will be sent to framework function
> > MPEG4Writer::exceedsFileSizeLimit(),
> > if the size reaches  (95 * mMaxFileSizeLimitBytes) / 100),
> > it will make a callback to tell gaia to stop recording ,
> > during the callback, 
> > the camera is still recording videos and the size is probably out of
> > mMaxFileSizeLimitBytes.
> > It may cause the problem.
> 
> Why couldn't the Writer stop writing at that moment?

I also got the same question. 

Xiaohong, could you explain more?

Comment 10

[Mike Habicher [:mikeh] (high bugzilla latency)]

When the file size limit is exceeded, the MPEG4Writer stops appending new video data to the file. When the Camera eventually calls stopRecording(), the MPEG4Writer commits the final index data to the file.

We found that in some cases, the space pre-allocated to this index data is insufficient, and patched our local version of MPEG4Writer in bug 987546.

Comment 11

[Julien Wajsberg [:julienw]]

So, is it a dupe to bug 987546 then?

Reporter, can you please precise the version you use?

Comment 12

[Chaochao Huang]

I think it's should be a dupe to bug bug 987546.

The details of version:
Gaia      fe0c0bcb572f23ea17170d5e9cac9f1a2415d6a6
Gecko     cce8003af6891737d9cd56208aa8eff2bec41ebd
BuildID   20140611130733
Version   28.1
ro.build.version.incremental=413
ro.build.date=Wed Jun 11 13:04:33 CST 2014

Comment 13

[Julien Wajsberg [:julienw]]

So please request the 1.3t+ blocking status on that bug if necessary.

Comment 14

[Julien Wajsberg [:julienw]]

I meant, please request it on bug 987546.

Comment 15

[Chaochao Huang]

(In reply to Julien Wajsberg [:julienw] from comment #14)
> I meant, please request it on bug 987546.

So sorry~