1031291 - Prepare comm-central to m-c changes from bug 762358

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Mike Hommey [:glandium]]

There are three issues in c-c's configure.in that prevent the patch from bug 762358 to work:
- It uses mozconfig-find from the mozilla tree while c-c has its own copy.
- It misuses $topsrcdir, which is not defined where it's being used (and I'm surprised it doesn't barf already)
- It doesn't output a mozinfo.json.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Prepare comm-central to m-c changes from bug 762358

Comment 2

[Joshua Cranmer [:jcranmer]]

(In reply to Mike Hommey [:glandium] from comment #0)
> - It misuses $topsrcdir, which is not defined where it's being used (and I'm
> surprised it doesn't barf already)

the AC_CONFIG_AUX_DIR currently checks in the output configure:
for ac_dir in ${MOZILLA_SRCDIR}/build/autoconf $srcdir/${MOZILLA_SRCDIR}/build/autoconf

... which is why it works. :-)

Comment 3

[Mike Hommey [:glandium]]

https://hg.mozilla.org/comm-central/rev/82fdf36eab59

Comment 4

[Mike Hommey [:glandium]]

Attachment: Ignore check-sync-dirs errors about mozconfig-find and mozconfig2client-mk

Comment 5

[Mike Hommey [:glandium]]

https://hg.mozilla.org/comm-central/rev/73d22071d91f

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 8447147 [details] [diff] [review]
Prepare comm-central to m-c changes from bug 762358

[Triage Comment]
Pushed to esr to fix bustage from bug 762358

https://hg.mozilla.org/releases/comm-esr31/rev/7d63cd3fe81d
https://hg.mozilla.org/releases/comm-esr31/rev/1f5fe3c2f33a