Closed
Bug 1031291
Opened 10 years ago
Closed 10 years ago
Prepare comm-central to m-c changes from bug 762358
Categories
(MailNews Core :: Build Config, defect)
MailNews Core
Build Config
Tracking
(thunderbird_esr3134+ fixed)
RESOLVED
FIXED
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(2 files)
1.81 KB,
patch
|
jcranmer
:
review+
standard8
:
approval-comm-esr31+
|
Details | Diff | Splinter Review |
541 bytes,
patch
|
jcranmer
:
review+
standard8
:
approval-comm-esr31+
|
Details | Diff | Splinter Review |
There are three issues in c-c's configure.in that prevent the patch from bug 762358 to work: - It uses mozconfig-find from the mozilla tree while c-c has its own copy. - It misuses $topsrcdir, which is not defined where it's being used (and I'm surprised it doesn't barf already) - It doesn't output a mozinfo.json.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8447147 -
Flags: review?(Pidgeot18)
Comment 2•10 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #0) > - It misuses $topsrcdir, which is not defined where it's being used (and I'm > surprised it doesn't barf already) the AC_CONFIG_AUX_DIR currently checks in the output configure: for ac_dir in ${MOZILLA_SRCDIR}/build/autoconf $srcdir/${MOZILLA_SRCDIR}/build/autoconf ... which is why it works. :-)
Updated•10 years ago
|
Attachment #8447147 -
Flags: review?(Pidgeot18) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/comm-central/rev/82fdf36eab59
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•10 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 4•10 years ago
|
||
Attachment #8449325 -
Flags: review?(Pidgeot18)
Updated•10 years ago
|
Attachment #8449325 -
Flags: review?(Pidgeot18) → review+
Assignee | ||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/comm-central/rev/73d22071d91f
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Comment 6•9 years ago
|
||
Comment on attachment 8447147 [details] [diff] [review] Prepare comm-central to m-c changes from bug 762358 [Triage Comment] Pushed to esr to fix bustage from bug 762358 https://hg.mozilla.org/releases/comm-esr31/rev/7d63cd3fe81d https://hg.mozilla.org/releases/comm-esr31/rev/1f5fe3c2f33a
Attachment #8447147 -
Flags: approval-comm-esr31+
Updated•9 years ago
|
Attachment #8449325 -
Flags: approval-comm-esr31+
Updated•9 years ago
|
status-thunderbird_esr31:
--- → fixed
tracking-thunderbird_esr31:
--- → 34+
You need to log in
before you can comment on or make changes to this bug.
Description
•