Closed Bug 1031291 Opened 10 years ago Closed 10 years ago

Prepare comm-central to m-c changes from bug 762358

Categories

(MailNews Core :: Build Config, defect)

defect
Not set
normal

Tracking

(thunderbird_esr3134+ fixed)

RESOLVED FIXED
Tracking Status
thunderbird_esr31 34+ fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(2 files)

There are three issues in c-c's configure.in that prevent the patch from bug 762358 to work:
- It uses mozconfig-find from the mozilla tree while c-c has its own copy.
- It misuses $topsrcdir, which is not defined where it's being used (and I'm surprised it doesn't barf already)
- It doesn't output a mozinfo.json.
Depends on: 1031009
Product: Thunderbird → MailNews Core
Version: unspecified → Trunk
(In reply to Mike Hommey [:glandium] from comment #0)
> - It misuses $topsrcdir, which is not defined where it's being used (and I'm
> surprised it doesn't barf already)

the AC_CONFIG_AUX_DIR currently checks in the output configure:
for ac_dir in ${MOZILLA_SRCDIR}/build/autoconf $srcdir/${MOZILLA_SRCDIR}/build/autoconf

... which is why it works. :-)
Attachment #8447147 - Flags: review?(Pidgeot18) → review+
https://hg.mozilla.org/comm-central/rev/82fdf36eab59
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #8449325 - Flags: review?(Pidgeot18) → review+
https://hg.mozilla.org/comm-central/rev/73d22071d91f
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
Comment on attachment 8447147 [details] [diff] [review]
Prepare comm-central to m-c changes from bug 762358

[Triage Comment]
Pushed to esr to fix bustage from bug 762358

https://hg.mozilla.org/releases/comm-esr31/rev/7d63cd3fe81d
https://hg.mozilla.org/releases/comm-esr31/rev/1f5fe3c2f33a
Attachment #8447147 - Flags: approval-comm-esr31+
Attachment #8449325 - Flags: approval-comm-esr31+
You need to log in before you can comment on or make changes to this bug.