If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

mach configure/build broken in c-c

RESOLVED FIXED in mozilla33

Status

()

Core
Build Config
--
major
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: clokep, Assigned: Paenglab)

Tracking

unspecified
mozilla33
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
The "Reject builds with pymake" patch from bug 1027890 seems to have broken building with comm-central. My guess is that the usage of topsrcdir is wrong in this case.

The error one gets is: "Exception: Could not find a suitable make implementation." on Mac (or the corresponding message about using mozmake for Windows).

I don't think I have the knowledge to fix this, but if someone points me in the right direction I can give it a try!
(Reporter)

Comment 1

3 years ago
Just to be explicit, I tested backing out rev 8aac3c8dc7bb from my copy of mozilla-central and I was able to run configure again. (And luckily it backs out cleanly.)
c-c's config/baseconfig.mk needs to get updates from at the very least bug 944650 and bug 1027890.
(Assignee)

Comment 3

3 years ago
Created attachment 8447012 [details] [diff] [review]
fixBuild.patch

With this patch I can build again with mach. This is a simple copy-n-paste, I don't know what I'm doing here. Apologies for unneeded changes.
Attachment #8447012 - Flags: review?(Pidgeot18)
Blocks: 1031291

Comment 4

3 years ago
Richard's patch *does* get Mach builds going again for me. I do have problems on a 'recurse to Libs' towards the end of the build however.  Building with mozmake directly bypasses that problem, which seems to be specific to my build envir. (Win7, vc11 with the win8 sdk.)
Attachment #8447012 - Flags: review?(Pidgeot18) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/2e3af17556ad
Assignee: nobody → richard.marti
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.