1031009 - mach configure/build broken in c-c

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Patrick Cloke [:clokep]]

The "Reject builds with pymake" patch from bug 1027890 seems to have broken building with comm-central. My guess is that the usage of topsrcdir is wrong in this case.

The error one gets is: "Exception: Could not find a suitable make implementation." on Mac (or the corresponding message about using mozmake for Windows).

I don't think I have the knowledge to fix this, but if someone points me in the right direction I can give it a try!

Comment 1

[Patrick Cloke [:clokep]]

Just to be explicit, I tested backing out rev 8aac3c8dc7bb from my copy of mozilla-central and I was able to run configure again. (And luckily it backs out cleanly.)

Comment 2

[Mike Hommey [:glandium]]

c-c's config/baseconfig.mk needs to get updates from at the very least bug 944650 and bug 1027890.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: fixBuild.patch

With this patch I can build again with mach. This is a simple copy-n-paste, I don't know what I'm doing here. Apologies for unneeded changes.

Comment 4

[Joe Sabash [:JoeS1]]

Richard's patch *does* get Mach builds going again for me. I do have problems on a 'recurse to Libs' towards the end of the build however.  Building with mozmake directly bypasses that problem, which seems to be specific to my build envir. (Win7, vc11 with the win8 sdk.)

Comment 5

[Joshua Cranmer [:jcranmer]]

https://hg.mozilla.org/comm-central/rev/2e3af17556ad