Crash with DASH video and MSE enabled

RESOLVED FIXED in mozilla33

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: benjamin, Assigned: kinetik)

Tracking

(Blocks 1 bug)

Trunk
mozilla33
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(crash signature)

Attachments

(2 attachments, 1 obsolete attachment)

Reporter

Description

5 years ago
Omega reported in bug 1031121 that he was experimenting with the youtube dash videos, and when he turned on MSE, he experienced crash bp-4053477d-79b0-4acd-9d56-c063e2140627.

This is a null-pointer exception at http://hg.mozilla.org/mozilla-central/annotate/be076357691c/content/media/mediasource/SourceBufferResource.h#l112 within SourceBufferResource::ResourceQueue::GetLength.

Filing separately from that bug so we can track the crash and the frame-rate issues separately.
Reporter

Updated

5 years ago
OS: Linux → Windows 7
Hardware: x86_64 → x86
See Also: → 1031121
Assignee

Comment 1

5 years ago
Just hit this on Linux while seeking on a DASH-enabled YouTube video (Titanfall video from bug 1031121): bp-e4bd8ec7-e212-4ec4-95fe-f0e3c2140715
Blocks: MSE, 1000686
OS: Windows 7 → All
Hardware: x86 → All
Version: unspecified → Trunk
Assignee

Comment 2

5 years ago
Looks like a threading issue, GetLength() is trying to iterate over items in an nsDeque and crashing inside a for-loop bounded on the nsDeque's GetSize() with a null pointer, suggesting the size of the nsDeque changed.

Evict() removes items from the nsDeque, and is called mainly by SourceBuffer::Append* which is called on the main thread.  Both of these crash signatures are on the decoder thread while waiting for data in a SourceBuffer.
Assignee

Updated

5 years ago
Attachment #8455926 - Attachment is obsolete: true
Assignee

Updated

5 years ago
Assignee: nobody → kinetik
Status: NEW → ASSIGNED
Assignee

Comment 4

5 years ago
Make a bunch of ResourceQueue functions private and remove some that are
unused.
Attachment #8455927 - Flags: review?(cajbir.bugzilla)

Updated

5 years ago
Attachment #8455927 - Flags: review?(cajbir.bugzilla) → review+

Updated

5 years ago
Attachment #8455928 - Flags: review?(cajbir.bugzilla) → review+
https://hg.mozilla.org/mozilla-central/rev/cc69e484c0e1
https://hg.mozilla.org/mozilla-central/rev/73300964c510
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.