1031593 - B2G cannot be built with GNU make 4.0

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[Jed Davis [:jld] ⟨⏰|UTC-8⟩ ⟦he/him⟧]

Because Android requires GNU make 3.81 or 3.82, and no other versions, by extension so does B2G.  As more Linux distributions upgrade, and as we continue to support B2G configurations based on old Android versions like ICS, this is likely to become a larger issue.

Do we want to do something about this?  If so, what?

Comment 1

[Nicholas Nethercote [inactive]]

I just hit this after upgrading to Ubuntu 14.10.

Comment 2

[Eric Rahm [:erahm]]

Note: The current work-around is the build/install an older version of make and use that when building b2g (one technique is to put /path/to/old-make/bin at the beginning of your search path).

Comment 3

[Augustin Trancart [:autra]]

I just disabled the check on my local copy, and building with make 4.0 works fine for the flame.

Comment 4

[Nicholas Nethercote [inactive]]

(In reply to Augustin Trancart [:autra] from comment #3)
> I just disabled the check on my local copy, and building with make 4.0 works
> fine for the flame.

I tried doing that with a Buri/Hamachi build and I got a failure very early during |./build.sh gecko|:

> build/core/prebuilt.mk:141: *** recipe commences before first target.  Stop.

With make 3.82 it's currently progressing normally.

Comment 6

[Kan-Ru Chen [:kanru] (UTC+9)]

New Debian stable is released and it comes with make 4.0 as well.

Comment 7

[Thomas Zimmermann [:tzimmermann] [:tdz]]

I just ran into this problem on Debian Jessie.

Can this be solved by adding a prebuilt make to our repositories and setting the MAKE variable in 'build.sh'?

Comment 8

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Another problem on Debian 8 is that there are no older compilers available for building Android code from ICS repositories. Is it possible to use one of the prebuilt compilers for this?

Comment 9

[Kan-Ru Chen [:kanru] (UTC+9)]

(In reply to Nicholas Nethercote [:njn] from comment #4)
> (In reply to Augustin Trancart [:autra] from comment #3)
> > I just disabled the check on my local copy, and building with make 4.0 works
> > fine for the flame.
> 
> I tried doing that with a Buri/Hamachi build and I got a failure very early
> during |./build.sh gecko|:
> 
> > build/core/prebuilt.mk:141: *** recipe commences before first target.  Stop.
> 
> With make 3.82 it's currently progressing normally.

I tried to build emulator with make 4.0 today but also encountered this error.

Comment 10

[Kan-Ru Chen [:kanru] (UTC+9)]

commenting out build/core/prebuilt.mk line 139 to line 145 let the build continues

Comment 11

[Kan-Ru Chen [:kanru] (UTC+9)]

looks like a bug introduced in build/core/prebuilt.mk rev 1b6d0a65fc62901f2c18d00c556bd5da50f35584 because it made line 139 to 145 dangling recipe commences

Comment 12

[Kan-Ru Chen [:kanru] (UTC+9)]

Attachment: patch

apply this patch under build/

Comment 13

[Ralph Giles (:rillian)]

Comment on attachment 8606093 [details] [diff] [review]
patch

Ping on this. Who can review this change? Looks like the prebuilt fix might no longer be necessary, so I think just the make version check is needed.

Comment 14

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8606093 [details] [diff] [review]
patch

Maybe mwu but clearly not me :)

Comment 15

[Michael Wu [:mwu]]

Comment on attachment 8606093 [details] [diff] [review]
patch

Review of attachment 8606093 [details] [diff] [review]:
-----------------------------------------------------------------

The main.mk part looks fine. I don't think we need the prebuilt.mk part. Please resubmit as a PR.

Comment 16

[Kan-Ru Chen [:kanru] (UTC+9)]

Attachment: https://github.com/mozilla-b2g/platform_build/pull/122

Comment 17

[Michael Wu [:mwu]]

Comment on attachment 8639667 [details] [review]
https://github.com/mozilla-b2g/platform_build/pull/122

r=me for this on master branch and any other branch this might apply to. (I think everything up to and including kitkat probably needs this..)

Comment 18

[Kan-Ru Chen [:kanru] (UTC+9)]

See comment 17.

Comment 19

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/platform_build/commit/1b0db93fb6b870b03467aff50d6419771ba0d88c