1031863 - Errors shown when saving classification/bug association aren't clear when the user has insufficient permissions

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[Phil Ringnalda (:philor)]

No idea whether this is just me, or general bustage, but

STR:

* Load https://treeherder.mozilla.org/ui/#/jobs?repo=mozilla-central&revision=afa67a2f7905
(* Log in using Persona as me? dunno)
* Click the Windows 8 opt Oth job
* Click the pushpin icon to add it to the pinboard
* Click the + next to the 1001948 bug suggestion
* Click the classification select list, choose intermittent
* Click save

Expected:

Job is shown as classified and annotated, clicking on it again shows the annotation in the Annotations tab

Actual:

Error messages are shown about Error saving classification and Error saving bug association, the Oth either does or sometimes does not show a * after it, but nothing is ever shown in the Annotations tab.

Comment 1

[Ed Morley [:emorley]]

If I try this when not logged in I get "must be logged in to classify jobs", so I'm presuming you were logged in at the time?

Currently classifying (starring) failures is limited to people with the sheriffing permissions (not ideal I know, only found out the other day) - filed bug 1032152.

It seems like this bug is either:
1) You had recently been given sheriffing permissions and the "log in/out needed to update permissions" issue is still present, or
2) When logged in (but with an account that doesn't have adequate permissions), the error message show doesn't state the correct reason (insufficient permissions).

I would guess #2 is most likely.

Until bug 1032152 is fixed this is a blocker, since it's going to confuse people testing, since they won't know to ask for permissions.

Comment 2

[Ed Morley [:emorley]]

Given bug 1031857 comment 3, #2 is looking like the reason.

Comment 3

[Cameron Dawson [:camd]]

We have removed the requirement of specific permissions to do this now.  So you just need to log in with Persona to provide an identity.

https://github.com/mozilla/treeherder-service/commit/fcbccc2f14bf9de2d1122942c3b92d0148676972

Comment 4

[Ed Morley [:emorley]]

(In reply to Cameron Dawson [:camd] from comment #3)
> We have removed the requirement of specific permissions to do this now.  So
> you just need to log in with Persona to provide an identity.

sgtm, thank you :-)