Steps to reproduce: 1) Set border properties on first-letter pseudo element Expected Bahvior: 1) Border around first-letter Actual Behavior: 1) No Border is visible This may be a regression. Builds as recent as 0.9.2 would show a border for first-letter pseudo elements, but 0.9.4 does not. Testcase to follow
Created attachment 52082 [details] testcase: set first-letter pseudo element to have a 3px black border
guess this is a regression.
This sounds like it's more likely to be a layout problem than style system.
99% sure this regressed with the rule tree landing. It worked in the 05-31 build, but not in the 06-01 build. Reassign to hyatt and putting [RULETREE] in summary
Oh boy oh boy oh boy!
Oh, there's code to do this intentionally in nsHTMLCSSStyleSheet. It just has to be removed in the right way.
What effect will this have on users of MachV?
Adding a "Dropped Initial" feature to Composer, I just discovered this bug too. We don't draw borders on :first-letter. IE and Opera don't have this bug. Konqueror has same bug.
Created attachment 82512 [details] [diff] [review] bring the :first-letter/:first-line rules in nsHTMLCSSStyleSheet mostly up to spec This is a preliminary patch.
It might be a better solution if we did this work in nsRuleNode.cpp like we do for :before and :after, though...
Created attachment 84214 [details] [diff] [review] slightly better patch; still some problems This one at least compiles and runs without assertions.
Taking the bug. This really needs to be a post-resolve callback, though.
And while I think of it, this should be fixed for XML documents too...
Also observed using FizzillaCFM/2002061014. Marking All/All.
*** Bug 188654 has been marked as a duplicate of this bug. ***
Doing it in the post resolve callback or in ApplyStyleFixups will break if someone does something like 'margin: inherit' and gets the struct from the parent, unless we go through a lot of work. I think I'll just go with what I have for now.
Created attachment 113147 [details] [diff] [review] patch Basically just updated.
Comment on attachment 113147 [details] [diff] [review] patch + // Disable everything in the Display struct except 'float' and + // 'clear'. This should be moved down to just before the code that actually does it, no? With that, looks good...
Fix checked in to trunk, 2003-02-22 11:20 PST. Still more work to be done here, so leaving open, at least until I file a separate bug on the various issues mentioned above.
What about those new bugs?
Created attachment 166811 [details] Testcase - margin:inherit David, is this the case you mentioned in comment 16?
Is there still something left to be done here?
Mozilla/5.0 (Windows NT 5.1; rv:7.0.1) Gecko/20100101 Firefox/7.0.1 The bug as reported is fixed. Attachment 166811 [details] (comment 21) should be a seperate bug.