1031959 - Add a_comment-end hook to show bug page

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[Simon Green]

Attachment: comment-v1.patch

This hook is used by Mozilla's Edit Comments extension, so it would be good to have it in the upstream code. All other eidt comment hooks already exist.

Comment 1

[Gervase Markham [:gerv]]

Comment on attachment 8447781 [details] [diff] [review]
comment-v1.patch

Are you sure the current filename is the right second argument to the Hook.process() call? The docs:
http://www.bugzilla.org/docs/tip/en/html/api/Bugzilla/Hook.html
suggest the second argument is a hash of parameters.

Gerv

Comment 2

[Simon Green]

(In reply to Gervase Markham [:gerv] from comment #1)
> Are you sure the current filename is the right second argument to the
> Hook.process() call? 

Yes.

> The docs:
> http://www.bugzilla.org/docs/tip/en/html/api/Bugzilla/Hook.html
> suggest the second argument is a hash of parameters.

The above documentation relates to code Hook. The hook in my patch is a template hook. The documentation of template hooks is at: http://www.bugzilla.org/docs/tip/en/html/api/Bugzilla/Template/Plugin/Hook.html

Comment 3

[Gervase Markham [:gerv]]

Comment on attachment 8447781 [details] [diff] [review]
comment-v1.patch

r=gerv.

Gerv

Comment 4

[Simon Green]

To ssh://[e-mail]/bugzilla/bugzilla.git
   171e504..70b1cb4  master -> master