103198 - Master Passwords preferences panel doesn't fit

Status: VERIFIED WORKSFORME

(Core Graveyard :: Security: UI, defect, P2)

Description

[sairuh (rarely reading bugmail)]

found using recent [today/yesterday] commercial trunk bits.

this is a problem on Mac OS 9.x and linux. so far this seems limited to the
classic theme.

this is *not* a problem on winNT or Mac OS 10.x.

to observe: open the Preferences dialog and go to Privacy & Security > Master
Passwords.

* on linux **classic theme only** the panel is clipped at the bottom.
* on mac 9.x **classic theme only** the panel is clipped at the bottom.
depending on your window manager on linux, you might be able to "workaround"
this by resizing the dialog. however, the usual UI rule of thumb with dialogs is
that the content should fit without forcing the user to resize.

Comment 1

[sairuh (rarely reading bugmail)]

nominating.

Comment 2

[Stephane Saux]

->javi

Comment 3

[Stephen Walker]

Attachment: patch; removes "If you have forgotten your master password, you can reset it."

Comment 4

[Matthew T (active 1999-2002)]

If the first line is removed, I suggest changing the second one to: `If you
reset your master password, all your stored Web and e-mail passwords, form data,
personal certificates, and private keys will be lost.' Otherwise it implies that
your stuff will be lost whether or not you reset your password.

For bonus points, add the missing ellipsis to the `Change Password...' button in
the same panel while you're there. :-)

Comment 5

[Stephen Walker]

Attachment: new patch with mpt's comments

Comment 6

[Kathleen :Brade]

ok, this is a nitpick... 
  If you reset your master password, all your stored Web ...
I'd prefer:
  If you reset your master password, all of your stored Web ...

Comment 7

[Stephen Walker]

Attachment: patch with brade's wording change

Comment 8

[Kai Engert [:KaiE:]]

I'm curious, on which Linux distribution / version / window manager do you see
this problem?

I tried on RedHat 7.1, with resolutions 640x480 and 1600x1200 with classic
theme, and in both resolutions the right side of this dialog only uses 85% of
the  available space (to the right of the tree control).


Another question: On your system, does "Edit Privacy/Cookies" fit completely? On
my system this panel uses even more space than "Master Passwords", but it still
fits without having to resize.

Taking over bug.

Comment 9

[Kai Engert [:KaiE:]]

-> PSM 2.2, as we have a fix.

Comment 10

[Kai Engert [:KaiE:]]

Comment on attachment 52970 [details] [diff] [review]
patch with brade's wording change

r=kaie

Comment 11

[sairuh (rarely reading bugmail)]

kai, i saw this running rh6.2, gnome desktop, with sawmill. [sorry about the old
versions...i'll be upgrading...sometime in the near future :)]

interestingly, the Cookies panel does manage to fit fine...

Comment 12

[Christopher Blizzard (:blizzard)]

Comment on attachment 52970 [details] [diff] [review]
patch with brade's wording change

sr=blizzard

Comment 13

[Kai Engert [:KaiE:]]

checked in -> fixed

Comment 14

[John Unruh]

Qa > sairuh, since I'm not seeing a panel that is clipped at the bottom with the 
11/10 Linux build or the 11/7 Mac OS 9.x build.

Comment 15

[sairuh (rarely reading bugmail)]

i check both modern and classic themes on linux rh7.2, winnt, mac 10.1.1 and mac
9.1 [emulated] --the Master Passwords panel is fine *except* for mac 9.1 in the
modern theme. so, i'm reopening this [let me know if you'd rather have a new,
separate bug, however].

tested using 2001.11.27-comm verif bits [trunk].

Comment 16

[andreww]

it might help to see a screen shot of it in the 9.1 version to see what is 
causing the overfow.

Comment 17

[sairuh (rarely reading bugmail)]

Attachment: modern/mac9.x: Master Passwords panel clipped at bottom

Comment 18

[John Unruh]

WFM with the 9.1 Modern and classic themes.

Comment 19

[sairuh (rarely reading bugmail)]

still a problem for me using 2002.02.14.08 comm bits --fwiw, i'm running 9.1
under X classic emulation mode.

Comment 20

[Kai Engert [:KaiE:]]

In that case I suggest we create a new separate tab for the reset functionality.

Doing that we also can revert the previous patch an go back to the longer
description.

Comment 21

[Kai Engert [:KaiE:]]

Additional suggestion for discussion, please vote what you prefer.

We could remove the "reset password" button, as well as the additional
explaining text, from the preferenes dialog, and make both elements become part
of the "change password" dailog.

Comment 22

[andreww]

Just a quick note - I do know that there are plans to make the mac version 
of the preferences panel slightly larger - so I wonder if after having a bit 
more space if things would fit ok.

Comment 23

[andreww]

After looking at the pref panel: would it be possible to place the "change 
password " and "reset password" buttons to the right of the descriptive text 
instead of below  them? that might reclaim some vertical space.

right now its
text text text
[button]

perhaps something like
text text [button]
in two columns..

Comment 24

[Kai Engert [:KaiE:]]

Andrew, for the planned Mac change, is there a bug we could depend on, so we can
check later when that is done?

Comment 25

[John Unruh]

nsbeta1

Comment 26

[John Unruh]

WFM with the 6/6 branch and trunk Mac 9.2.2 and Linux builds.

Comment 27

[John Unruh]

Verified.