Master Passwords preferences panel doesn't fit

VERIFIED WORKSFORME

Status

Core Graveyard
Security: UI
P2
major
VERIFIED WORKSFORME
17 years ago
a year ago

People

(Reporter: sairuh (rarely reading bugmail), Assigned: kaie)

Tracking

(Blocks: 1 bug, {polish})

1.0 Branch
psm2.2
PowerPC
Mac System 9.x
polish
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

17 years ago
found using recent [today/yesterday] commercial trunk bits.

this is a problem on Mac OS 9.x and linux. so far this seems limited to the
classic theme.

this is *not* a problem on winNT or Mac OS 10.x.

to observe: open the Preferences dialog and go to Privacy & Security > Master
Passwords.

* on linux **classic theme only** the panel is clipped at the bottom.
* on mac 9.x **classic theme only** the panel is clipped at the bottom.
depending on your window manager on linux, you might be able to "workaround"
this by resizing the dialog. however, the usual UI rule of thumb with dialogs is
that the content should fit without forcing the user to resize.
(Reporter)

Comment 1

17 years ago
nominating.
Blocks: 80392
Keywords: mozilla0.9.6, polish

Comment 2

17 years ago
->javi
Assignee: ssaux → javi
Priority: -- → P2
Target Milestone: --- → Future

Comment 3

17 years ago
Created attachment 52794 [details] [diff] [review]
patch; removes "If you have forgotten your master password, you can reset it."

Comment 4

17 years ago
If the first line is removed, I suggest changing the second one to: `If you
reset your master password, all your stored Web and e-mail passwords, form data,
personal certificates, and private keys will be lost.' Otherwise it implies that
your stuff will be lost whether or not you reset your password.

For bonus points, add the missing ellipsis to the `Change Password...' button in
the same panel while you're there. :-)

Comment 5

17 years ago
Created attachment 52848 [details] [diff] [review]
new patch with mpt's comments

Comment 6

17 years ago
ok, this is a nitpick... 
  If you reset your master password, all your stored Web ...
I'd prefer:
  If you reset your master password, all of your stored Web ...

Comment 7

17 years ago
Created attachment 52970 [details] [diff] [review]
patch with brade's wording change
(Assignee)

Comment 8

17 years ago
I'm curious, on which Linux distribution / version / window manager do you see
this problem?

I tried on RedHat 7.1, with resolutions 640x480 and 1600x1200 with classic
theme, and in both resolutions the right side of this dialog only uses 85% of
the  available space (to the right of the tree control).


Another question: On your system, does "Edit Privacy/Cookies" fit completely? On
my system this panel uses even more space than "Master Passwords", but it still
fits without having to resize.

Taking over bug.
Assignee: javi → kaie
(Assignee)

Comment 9

17 years ago
-> PSM 2.2, as we have a fix.
Status: NEW → ASSIGNED
(Assignee)

Updated

17 years ago
Attachment #52794 - Attachment is obsolete: true
(Assignee)

Updated

17 years ago
Attachment #52848 - Attachment is obsolete: true
(Assignee)

Comment 10

17 years ago
Comment on attachment 52970 [details] [diff] [review]
patch with brade's wording change

r=kaie
Attachment #52970 - Flags: review+
(Assignee)

Updated

17 years ago
Target Milestone: Future → 2.2
(Reporter)

Comment 11

17 years ago
kai, i saw this running rh6.2, gnome desktop, with sawmill. [sorry about the old
versions...i'll be upgrading...sometime in the near future :)]

interestingly, the Cookies panel does manage to fit fine...

Updated

17 years ago
Blocks: 103711
Comment on attachment 52970 [details] [diff] [review]
patch with brade's wording change

sr=blizzard
Attachment #52970 - Flags: superreview+
(Assignee)

Comment 13

16 years ago
checked in -> fixed
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 14

16 years ago
Qa > sairuh, since I'm not seeing a panel that is clipped at the bottom with the 
11/10 Linux build or the 11/7 Mac OS 9.x build.
QA Contact: junruh → sairuh
Version: 1.01 → 2.1
(Reporter)

Comment 15

16 years ago
i check both modern and classic themes on linux rh7.2, winnt, mac 10.1.1 and mac
9.1 [emulated] --the Master Passwords panel is fine *except* for mac 9.1 in the
modern theme. so, i'm reopening this [let me know if you'd rather have a new,
separate bug, however].

tested using 2001.11.27-comm verif bits [trunk].
Status: RESOLVED → REOPENED
OS: All → Mac System 9.x
Hardware: All → Macintosh
Resolution: FIXED → ---

Comment 16

16 years ago
it might help to see a screen shot of it in the 9.1 version to see what is 
causing the overfow.
(Reporter)

Comment 17

16 years ago
Created attachment 59465 [details]
modern/mac9.x: Master Passwords panel clipped at bottom

Comment 18

16 years ago
WFM with the 9.1 Modern and classic themes.
Status: REOPENED → RESOLVED
Last Resolved: 16 years ago16 years ago
Resolution: --- → WORKSFORME
(Reporter)

Comment 19

16 years ago
still a problem for me using 2002.02.14.08 comm bits --fwiw, i'm running 9.1
under X classic emulation mode.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
(Assignee)

Comment 20

16 years ago
In that case I suggest we create a new separate tab for the reset functionality.

Doing that we also can revert the previous patch an go back to the longer
description.
(Assignee)

Comment 21

16 years ago
Additional suggestion for discussion, please vote what you prefer.

We could remove the "reset password" button, as well as the additional
explaining text, from the preferenes dialog, and make both elements become part
of the "change password" dailog.

Comment 22

16 years ago
Just a quick note - I do know that there are plans to make the mac version 
of the preferences panel slightly larger - so I wonder if after having a bit 
more space if things would fit ok.

Comment 23

16 years ago
After looking at the pref panel: would it be possible to place the "change 
password " and "reset password" buttons to the right of the descriptive text 
instead of below  them? that might reclaim some vertical space.

right now its
text text text
[button]

perhaps something like
text text [button]
in two columns..


(Assignee)

Comment 24

16 years ago
Andrew, for the planned Mac change, is there a bug we could depend on, so we can
check later when that is done?

Comment 25

16 years ago
nsbeta1
Keywords: nsbeta1

Updated

16 years ago
Keywords: nsbeta1 → nsbeta1-
Keywords: mozilla0.9.6

Comment 26

16 years ago
WFM with the 6/6 branch and trunk Mac 9.2.2 and Linux builds.
Status: REOPENED → RESOLVED
Last Resolved: 16 years ago16 years ago
Resolution: --- → WORKSFORME

Comment 27

16 years ago
Verified.
Status: RESOLVED → VERIFIED
QA Contact: sairuh → junruh
(Reporter)

Updated

15 years ago
Blocks: 133627
(Reporter)

Updated

15 years ago
No longer blocks: 80392

Updated

13 years ago
Component: Security: UI → Security: UI
Product: PSM → Core

Updated

10 years ago
Version: psm2.1 → 1.0 Branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.