Closed
Bug 1032001
Opened 11 years ago
Closed 11 years ago
Fix jshint error for build/copy-build-stage-data.js
Categories
(Firefox OS Graveyard :: Gaia::Build, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: yurenju, Assigned: xfq, Mentored)
References
Details
(Whiteboard: [good first bug][mentor-lang=zh])
Attachments
(1 file, 1 obsolete file)
+++ This bug was initially created as a clone of Bug #1032000 +++
|
Reporter | |
Updated•11 years ago
|
Mentor: yurenju.mozilla
Whiteboard: [good first bug][mentor-lang=zh]
|
||
Comment 1•11 years ago
|
||
Some guidance on how to approach this bug is available here:
https://bugzilla.mozilla.org/show_bug.cgi?id=1032045#c2
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #8463794 -
Flags: review?(yurenju.mozilla)
|
|
Reporter | |
Updated•11 years ago
|
Assignee: nobody → xfq.free
|
|
Reporter | |
Comment 3•11 years ago
|
||
Comment on attachment 8463794 [details] [review]
PR on GitHub
looks good but conflict. please rebase, push then set needinfo? flag to me to merge this pr.
Attachment #8463794 -
Flags: review?(yurenju.mozilla) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Here's the new pull request.
Attachment #8463794 -
Attachment is obsolete: true
Attachment #8481891 -
Flags: review+
|
|
Reporter | |
Comment 5•11 years ago
|
||
merged.
https://github.com/mozilla-b2g/gaia/commit/afc97447207a68b7c23c74f23afeb91a7fe4ae05
:xfq, you have to set needinfo flag to me or I can't notice you need my help to merge.
Flags: needinfo?(xfq.free)
|
|
Reporter | |
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 6•11 years ago
|
||
(In reply to Yuren [:yurenju] from comment #5)
> merged.
[...]
> :xfq, you have to set needinfo flag to me or I can't notice you need my help
> to merge.
I see. Thank you!
Flags: needinfo?(xfq.free)
You need to log in
before you can comment on or make changes to this bug.
Description
•