Closed
Bug 1032004
Opened 10 years ago
Closed 10 years ago
Fix jshint error for build/csslinter.js
Categories
(Firefox OS Graveyard :: Gaia::Build, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: yurenju, Assigned: ShellHacker, Mentored)
References
Details
(Whiteboard: [good first bug][mentor-lang=zh])
Attachments
(2 files)
630 bytes,
patch
|
Details | Diff | Splinter Review | |
46 bytes,
text/x-github-pull-request
|
Details | Review |
+++ This bug was initially created as a clone of Bug #1032002 +++
Reporter | ||
Updated•10 years ago
|
Mentor: yurenju.mozilla
Whiteboard: [good first bug][mentor-lang=zh]
Comment 1•10 years ago
|
||
Some guidance on how to approach this bug is available here: https://bugzilla.mozilla.org/show_bug.cgi?id=1032045#c2
Assignee | ||
Comment 2•10 years ago
|
||
I want to work on this, running jshint on the build file for this results in 1001 errors. Self assigning this. Would need mentoring :)
Assignee: nobody → sudheesh1995
Flags: needinfo?(yurenju.mozilla)
Assignee | ||
Comment 3•10 years ago
|
||
I could silence most warnings by using ``` 'use strict'; /* jshint -W109, -W101 */ ``` But the 72 pending errors now are about functions which aren't being used. eg. ``` . . . build/csslinter.js: line 5857, col 16, 'count' is defined but never used. build/csslinter.js: line 5858, col 13, 'msg' is defined but never used. build/csslinter.js: line 5859, col 13, 'types' is defined but never used. build/csslinter.js: line 5860, col 13, 'last' is defined but never used. . . . ``` One way to silence them is to use the ``` /* exported CSSLint */ /* exported last */ /* exported count */ . . . ``` which is a tedious process, is there a better approach ?
Assignee | ||
Comment 4•10 years ago
|
||
Figured out a way to do the long process. Would be happy to get this reviewed, will be very happy to fix the other similar bugs.
Attachment #8465500 -
Flags: review?(yurenju.mozilla)
Assignee | ||
Comment 5•10 years ago
|
||
Reporter | ||
Comment 6•10 years ago
|
||
Hi Sudheesh, after taking a look into csslinter, I found this script came from another project, for this kind of scenario we usually want to fix the issue on upstream project, but I didn't realize it when I filed this bug, sorry for that. thanks your contribution and I will close this bug as WONTFIX. I will also check other bugs for jshint if they come from other project.
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: needinfo?(yurenju.mozilla)
Resolution: --- → WONTFIX
Reporter | ||
Updated•10 years ago
|
Attachment #8465500 -
Flags: review?(yurenju.mozilla)
You need to log in
before you can comment on or make changes to this bug.
Description
•