1032004 - Fix jshint error for build/csslinter.js

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

+++ This bug was initially created as a clone of Bug #1032002 +++

Comment 1

[Mike Hoye [:mhoye]]

Some guidance on how to approach this bug is available here:

https://bugzilla.mozilla.org/show_bug.cgi?id=1032045#c2

Comment 2

[Sudheesh Singanamalla (:ShellHacker)]

I want to work on this, running jshint on the build file for this results in 1001 errors. Self assigning this. Would need mentoring :)

Comment 3

[Sudheesh Singanamalla (:ShellHacker)]

I could silence most warnings by using
```
'use strict';
/* jshint -W109, -W101 */
```

But the 72 pending errors now are about functions which aren't being used.
eg. 
```
.
.
.
build/csslinter.js: line 5857, col 16, 'count' is defined but never used.
build/csslinter.js: line 5858, col 13, 'msg' is defined but never used.
build/csslinter.js: line 5859, col 13, 'types' is defined but never used.
build/csslinter.js: line 5860, col 13, 'last' is defined but never used.
.
.
.
```

One way to silence them is to use the 
```
/* exported CSSLint */
/* exported last */
/* exported count */
.
.
.
```

which is a tedious process, is there a better approach ?

Comment 4

[Sudheesh Singanamalla (:ShellHacker)]

Attachment: Patch_1032004.patch

Figured out a way to do the long process. Would be happy to get this reviewed, will be very happy to fix the other similar bugs.

Comment 5

[Sudheesh Singanamalla (:ShellHacker)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/22360

Comment 6

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Hi Sudheesh,

after taking a look into csslinter, I found this script came from another project, for this kind of scenario we usually want to fix the issue on upstream project, but I didn't realize it when I filed this bug, sorry for that.

thanks your contribution and I will close this bug as WONTFIX.

I will also check other bugs for jshint if they come from other project.