Closed Bug 1032008 Opened 12 years ago Closed 11 years ago

Fix jshint error for build/jshint/xfail.js

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Build
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: yurenju, Assigned: xfq, Mentored)

References

Details

(Whiteboard: [good first bug][mentor-lang=zh])

Attachments

(1 file, 1 obsolete file)

PRv2 on GitHub
46 bytes, text/x-github-pull-request
yurenju
: review+
Details | Review
+++ This bug was initially created as a clone of Bug #1032006 +++
Mentor: yurenju.mozilla
Whiteboard: [good first bug][mentor-lang=zh]
Some guidance on how to approach this bug is available here: https://bugzilla.mozilla.org/show_bug.cgi?id=1032045#c2
Attached file PR on GitHub (obsolete) —
Attachment #8464032 - Flags: review?(yurenju.mozilla)
Assignee: nobody → xfq.free
hi xfq, looks build bot does not work for your pull request, can you rebase and push again?
Flags: needinfo?(xfq.free)
I'm not quite familiar with Git. Could you please have a look at the pull request now?
Flags: needinfo?(xfq.free)
xfq, you can find me on IRC irc.mozilla.org (#gaia for english and #mozilla-taiwan for chinese)
just saw your branch, I think the better way is create another branch from master, and use |git cherry-pick ffe4428c11f1d8eb873cd3454fc9f15f80540ad0|[1] to pick your change. then you will get conflict from another change, solve it and use |git add| the file then use |git cherry-pick --continue| to contiune cherry-pick. feel free to find me on IRC. [1] https://github.com/xfq/gaia/commit/ffe4428c11f1d8eb873cd3454fc9f15f80540ad0
Comment on attachment 8464032 [details] [review] PR on GitHub canceled review request. there are some git articles in chinese FYR. http://blog.winwu.today/2013/04/git-cherry-pick.html http://blog.longwin.com.tw/2009/05/git-learn-initial-command-2009/
Attachment #8464032 - Flags: review?(yurenju.mozilla)
Thank you!
Attached file PRv2 on GitHub —
Here's my new pull request.
Attachment #8464032 - Attachment is obsolete: true
Attachment #8481105 - Flags: review?(yurenju.mozilla)
Comment on attachment 8481105 [details] [review] PRv2 on GitHub looks good, r=yurenju
Attachment #8481105 - Flags: review?(yurenju.mozilla) → review+
merged, thanks for your contribution! https://github.com/mozilla-b2g/gaia/commit/c90ae61a7a30b0b1da8512018a080bc742a098a0
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: