Closed Bug 1032028 Opened 11 years ago Closed 11 years ago

Fix jshint error for build/settings.js

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Build
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: yurenju, Assigned: arvin0731, Mentored)

References

Details

(Whiteboard: [good first bug][mentor-lang=zh])

Attachments

(2 files)

PR link
46 bytes, text/x-github-pull-request
Details | Review
PR link
46 bytes, text/x-github-pull-request
yurenju
: review+
Details | Review
+++ This bug was initially created as a clone of Bug #1032026 +++
Whiteboard: [good first bug][mentor-lang=zh]
Some guidance on how to approach this bug is available here: https://bugzilla.mozilla.org/show_bug.cgi?id=1032045#c2
jshint (v2.5.2) didn't detect any error/warning in this file on my machine. Should this bug be closed?
Flags: needinfo?(yurenju.mozilla)
I still got 17 error since remove build/settings.js from .jshintignore.
Flags: needinfo?(yurenju.mozilla)
https://github.com/mozilla-b2g/gaia/pull/22454 please check. Thanks!
Assignee: nobody → arvin0731
Arvin, You should put your PR link to the attachment and set review flag to yurenju. Thanks!
Attached file PR link —
Attachment #8467088 - Flags: review?(yurenju.mozilla)
ArvinH, I just record a video for how to rebase, take a look! :-) https://asciinema.org/a/11316
Attachment #8467088 - Flags: review?(yurenju.mozilla)
sorry comment to wrong bug :-/ but actually your pull request have two commits and one of these commits is for jshint error of utils.js, you should remove it, so also canceled review request.
Comment on attachment 8467088 [details] [review] PR link https://github.com/mozilla-b2g/gaia/pull/22555
Attachment #8467088 - Flags: review?(yurenju.mozilla)
I just update my pull request for this bug, please take a look, Thanks!
Comment on attachment 8467088 [details] [review] PR link AvrinH, I left some comments on github, please check it, you are close to get r+ :D please set me review again if pull request is updated.
Attachment #8467088 - Flags: review?(yurenju.mozilla)
Attachment #8467088 - Flags: review?(yurenju.mozilla)
I also update the other pull request for Bug 1032041 please check it, thank you so much!
ArvinH, there are still two commit in this pull request and it's closed, can you re-open it and remove commit for utils.js?
Attachment #8467088 - Flags: review?(yurenju.mozilla)
Hi Yuren, because I want to arrange my branches, so I just directly created another branch for this bug, and comment the new PR link on attachment :p and that's why I close the previous pull request. Can I just delete the old branch, and create a new attachment for new pull request? btw, here is the new pull request https://github.com/mozilla-b2g/gaia/pull/22555
Hi Yuren, it has been two weeks, how can I fix this? so I can't just create new pull request? If so, I will reopen the previous pull request and try to remove the commits. Thanks for helping.
Hi ArvinH, you have to set needinfo flag to me or I can't notice your comment since I got a lot of bugmail in my mailbox :-) and your pull request still have two commits, please squash it and *needinfo* or send review request to me.
Flags: needinfo?(arvin0731)
Hi Yuren, I squash my pull request (this one, https://github.com/mozilla-b2g/gaia/pull/22555) please check, thanks:)
Flags: needinfo?(arvin0731)
Attachment #8467088 - Flags: review?(yurenju.mozilla)
Flags: needinfo?(yurenju.mozilla)
Comment on attachment 8467088 [details] [review] PR link you still have tow commits in your pull request, here is a screencast for squashing commits https://asciinema.org/a/11269 and please find me on irc.mozilla.org #gaia channel if you have any questions.
Attachment #8467088 - Flags: review?(yurenju.mozilla)
Flags: needinfo?(yurenju.mozilla)
Flags: needinfo?(yurenju.mozilla)
why did you needinfo? me without any information?
Flags: needinfo?(yurenju.mozilla)
Comment on attachment 8467088 [details] [review] PR link Hi, I think I fix all problems, please take a look. Thank you!
Attachment #8467088 - Flags: review?(yurenju.mozilla)
Comment on attachment 8467088 [details] [review] PR link ArvinH, that is a closed pull request, could you check it again? https://github.com/mozilla-b2g/gaia/pull/22454
Attachment #8467088 - Flags: review?(yurenju.mozilla)
sorry, not that one This one is the correct one pull request: https://github.com/mozilla-b2g/gaia/pull/22555 and I think this one have bug number in request title Thanks!
Attached file PR link —
Attachment #8484029 - Flags: review?(yurenju.mozilla)
Attachment #8484029 - Attachment description: Bug 1032028 - fix jshint error in build/settings.js → PR link
Comment on attachment 8484029 [details] [review] PR link r=yurenju
Attachment #8484029 - Flags: review?(yurenju.mozilla) → review+
merged, thanks for your contribution! https://github.com/mozilla-b2g/gaia/commit/1f1baf47124efe08bf5b77372703de002bf80cd5
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: