make sure visibility APIs work in social/loop panels, deprecate *FrameShow/Hide

RESOLVED FIXED in Firefox 48

Status

()

Firefox
SocialAPI
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

Tracking

Trunk
Firefox 48
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
The visibility APIs are standard APIs, we should really use those rather than the *FrameShow/Hide events that socialapi introduced.  For the status panel, PanelFrame.jsm needs to be modified to set isActive=true in the popupshown event, and isActive=false in the popuphidden event.  Setting isActive will cause the regular visibility API events to be sent.
(Assignee)

Comment 1

2 years ago
Created attachment 8718653 [details] [diff] [review]
remove custom shown/hidden events (use visibilityapi)
Attachment #8718653 - Flags: feedback?(markh)
(Assignee)

Updated

2 years ago
Depends on: 898706
(Assignee)

Updated

2 years ago
Assignee: nobody → mixedpuppy
Comment on attachment 8718653 [details] [diff] [review]
remove custom shown/hidden events (use visibilityapi)

Review of attachment 8718653 [details] [diff] [review]:
-----------------------------------------------------------------

What's not to love about ripping code out :) I'm assuming you are taking care of the providers (lack of?) usage of this, so it LGTM.
Attachment #8718653 - Flags: feedback?(markh) → feedback+
(Assignee)

Comment 3

2 years ago
Created attachment 8730357 [details] [diff] [review]
remove custom shown/hidden events (use visibilityapi)

move to review.  chat window still provides these events, bug 1256431 is a followup for hello.
Attachment #8718653 - Attachment is obsolete: true
Attachment #8730357 - Flags: review?(markh)
(Assignee)

Updated

2 years ago
Blocks: 1256431
(Assignee)

Comment 4

2 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b9726ae67d6a
(Assignee)

Comment 5

2 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=79dbd143662b
Comment on attachment 8730357 [details] [diff] [review]
remove custom shown/hidden events (use visibilityapi)

Review of attachment 8730357 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/socialchat.xml
@@ +151,5 @@
>          </getter>
>          <setter>
>            this.content.docShellIsActive = !!val;
>  
> +          // Bug 1256431 hello needs to use visibility api

Can you please expand this comment - it wasn't obvious to me without looking at that bug. Something like "We still send these events for loop - bug xxx is to remove them" or something :)
Attachment #8730357 - Flags: review?(markh) → review+
(Assignee)

Comment 7

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/d9cc905f0f37faa8d1da6e449709d261eda4933b
Bug 1032398 repalce socialShow/Hide with visibility api, r=markh

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d9cc905f0f37
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in before you can comment on or make changes to this bug.