Closed Bug 1032398 Opened 6 years ago Closed 4 years ago

make sure visibility APIs work in social/loop panels, deprecate *FrameShow/Hide

Categories

(Firefox Graveyard :: SocialAPI, defect)

x86
macOS
defect
Not set

Tracking

(firefox48 fixed)

RESOLVED FIXED
Firefox 48
Tracking Status
firefox48 --- fixed

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

References

Details

Attachments

(1 file, 1 obsolete file)

The visibility APIs are standard APIs, we should really use those rather than the *FrameShow/Hide events that socialapi introduced.  For the status panel, PanelFrame.jsm needs to be modified to set isActive=true in the popupshown event, and isActive=false in the popuphidden event.  Setting isActive will cause the regular visibility API events to be sent.
Attachment #8718653 - Flags: feedback?(markh)
Depends on: 898706
Assignee: nobody → mixedpuppy
Comment on attachment 8718653 [details] [diff] [review]
remove custom shown/hidden events (use visibilityapi)

Review of attachment 8718653 [details] [diff] [review]:
-----------------------------------------------------------------

What's not to love about ripping code out :) I'm assuming you are taking care of the providers (lack of?) usage of this, so it LGTM.
Attachment #8718653 - Flags: feedback?(markh) → feedback+
move to review.  chat window still provides these events, bug 1256431 is a followup for hello.
Attachment #8718653 - Attachment is obsolete: true
Attachment #8730357 - Flags: review?(markh)
Blocks: 1256431
Comment on attachment 8730357 [details] [diff] [review]
remove custom shown/hidden events (use visibilityapi)

Review of attachment 8730357 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/socialchat.xml
@@ +151,5 @@
>          </getter>
>          <setter>
>            this.content.docShellIsActive = !!val;
>  
> +          // Bug 1256431 hello needs to use visibility api

Can you please expand this comment - it wasn't obvious to me without looking at that bug. Something like "We still send these events for loop - bug xxx is to remove them" or something :)
Attachment #8730357 - Flags: review?(markh) → review+
https://hg.mozilla.org/mozilla-central/rev/d9cc905f0f37
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.