"builtin" manifest support was only ever necessary with facebook in the very early days of socialapi. Time to just remove it, we have other activation avenues that have been around for a while now.
Might as well nix the whitelist activation as well, it is no longer used.
Summary: remove "builtin" manifest support → remove "builtin" and "whitelist" manifest support
Created attachment 8448437 [details] [diff] [review] remove builtin and whitelist patch also renames addBuiltinProvider -> enableProvider and removeProvider -> disableProvider. The new names actually match the functionality that these have provided for the past year, they are the corresponding functions the addon manager users to enable/disable the providers. I did that because I got a little lost when fixing one of the test files. The "whitelist" partially remains to continue supporting localStorage in the frameworker for cliqz, will reach out and get them to stop using localStorage.
Assignee: nobody → mixedpuppy
Attachment #8448437 - Flags: review?(felipc)
Comment on attachment 8448437 [details] [diff] [review] remove builtin and whitelist code removal, yay!!
Attachment #8448437 - Flags: review?(felipc) → review+
Created attachment 8458800 [details] [diff] [review] remove builtin and whitelist minor bit-rot changes and xpcshell test fix https://hg.mozilla.org/integration/fx-team/rev/f1ab07827b04
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
23 days ago
Whiteboard: [tor 13612]
You need to log in before you can comment on or make changes to this bug.