Closed Bug 1032432 Opened 5 years ago Closed 5 years ago

remove "builtin" and "whitelist" manifest support

Categories

(Firefox Graveyard :: SocialAPI, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 33

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

Details

(Whiteboard: [tor 13612])

Attachments

(1 file, 1 obsolete file)

"builtin" manifest support was only ever necessary with facebook in the very early days of socialapi.  Time to just remove it, we have other activation avenues that have been around for a while now.
Might as well nix the whitelist activation as well, it is no longer used.
Summary: remove "builtin" manifest support → remove "builtin" and "whitelist" manifest support
Attached patch remove builtin and whitelist (obsolete) — Splinter Review
patch also renames addBuiltinProvider -> enableProvider and removeProvider -> disableProvider.  The new names actually match the functionality that these have provided for the past year, they are the corresponding functions the addon manager users to enable/disable the providers.  I did that because I got a little lost when fixing one of the test files.

The "whitelist" partially remains to continue supporting localStorage in the frameworker for cliqz, will reach out and get them to stop using localStorage.
Assignee: nobody → mixedpuppy
Attachment #8448437 - Flags: review?(felipc)
Comment on attachment 8448437 [details] [diff] [review]
remove builtin and whitelist

code removal, yay!!
Attachment #8448437 - Flags: review?(felipc) → review+
minor bit-rot changes and xpcshell test fix

https://hg.mozilla.org/integration/fx-team/rev/f1ab07827b04
Attachment #8448437 - Attachment is obsolete: true
Attachment #8458800 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/f1ab07827b04
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
Whiteboard: [tor 13612]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.