remove "builtin" and "whitelist" manifest support

RESOLVED FIXED in Firefox 33

Status

()

Firefox
SocialAPI
RESOLVED FIXED
4 years ago
23 days ago

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

Tracking

Trunk
Firefox 33
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [tor 13612])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
"builtin" manifest support was only ever necessary with facebook in the very early days of socialapi.  Time to just remove it, we have other activation avenues that have been around for a while now.
(Assignee)

Comment 1

4 years ago
Might as well nix the whitelist activation as well, it is no longer used.
Summary: remove "builtin" manifest support → remove "builtin" and "whitelist" manifest support
(Assignee)

Comment 2

4 years ago
Created attachment 8448437 [details] [diff] [review]
remove builtin and whitelist

patch also renames addBuiltinProvider -> enableProvider and removeProvider -> disableProvider.  The new names actually match the functionality that these have provided for the past year, they are the corresponding functions the addon manager users to enable/disable the providers.  I did that because I got a little lost when fixing one of the test files.

The "whitelist" partially remains to continue supporting localStorage in the frameworker for cliqz, will reach out and get them to stop using localStorage.
Assignee: nobody → mixedpuppy
Attachment #8448437 - Flags: review?(felipc)
Comment on attachment 8448437 [details] [diff] [review]
remove builtin and whitelist

code removal, yay!!
Attachment #8448437 - Flags: review?(felipc) → review+
(Assignee)

Comment 5

4 years ago
Created attachment 8458800 [details] [diff] [review]
remove builtin and whitelist

minor bit-rot changes and xpcshell test fix

https://hg.mozilla.org/integration/fx-team/rev/f1ab07827b04
Attachment #8448437 - Attachment is obsolete: true
Attachment #8458800 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/f1ab07827b04
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
Whiteboard: [tor 13612]
You need to log in before you can comment on or make changes to this bug.