Closed Bug 1032448 Opened 11 years ago Closed 11 years ago

Treeherder "Get next 10 resultsets" is slower than TBPL

Categories

(Tree Management :: Treeherder, defect, P1)

Product:
Tree Management
Component:
Treeherder
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: emorley, Assigned: jeads)

References

Details

(Keywords: perf)

1) With a warm browser cache, open https://treeherder.mozilla.org/ui/#/jobs?repo=mozilla-inbound 2) Wait for the page to finish loading & then scroll to the bottom of the page. 3) Click the "10" button to load 10 additional resultsets 4) Repeat for https://tbpl.mozilla.org/?tree=Mozilla-Inbound (use the green arrow at the bottom, which also loads 10 additional pushes). Expected: Equal (or faster) time compared to TBPL. Actual: Treeherder takes ~11 seconds until any (and all) results/pushes appear. TBPL displays all additional pushes + the first few sets of results after ~2 seconds, and all results by the time ~6 seconds have passed.
Meant to add: I was hoping this and bug 1032437/bug 1032216 would be resolved once we switched to production hardware, but unfortunately it's still slower than TBPL.
Priority: -- → P1
Assignee: nobody → jeads
Status: NEW → ASSIGNED
We addressed these performance issues by doing the following things: 1.) Reducing the size of data returned from the web service by removing redundant job object property names. https://github.com/mozilla/treeherder-service/pull/180 https://github.com/mozilla/treeherder-ui/pull/106 2.) Re-structuring the web service requests from the UI so that they are performed in parallel using the $q service in angularjs. I also separated out the retrieval of the resultsets/pushes onto their own web service call. I think this will remove the occasional javascript non-responsive message because the application regains control to render after each request returns. The individual HTTP request round trips are much faster than one single request, by doing them in parallel the end-to-end load time seems very comparable to tbpl. https://github.com/mozilla/treeherder-service/pull/182 https://github.com/mozilla/treeherder-ui/pull/115 If this is still an issue for anyone please re-open this bug and needinfo jeads.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Keywords: perf
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/8b798b785c40a16ef1461f5adea8716cb832aa70 Remove job property names from resultset web service data to improve page load performance (Bugs 1032437 1032216 1032448 1042621)
You need to log in before you can comment on or make changes to this bug.