1032483 - Duplicate client records from June 26th and June 27th Fennec Nightly builds

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Nick Alexander :nalexander [he/him]]

rnewman and Mossop report duplicate Android client records.

The duplicate records arise due to a landing Bug 929865, which (incorrectly) changed the GlobalConstants.BROWSER_INTENT_PACKAGE_NAME.  That package name is folded into the Sync SharedPrefs file; changing the package name meant that Sync sees no shared preferences at all, and hence generates a new client GUID.  That's how we got duplicate client records.

Bug 1030734 fixed the incorrect change above.

The bad window contains the two Nightly builds of June 26th and June 27th.

Comment 1

[Nick Alexander :nalexander [he/him]]

The next action is to verify that updating from the June 25th to June 28th Nightly is clean; I'll do that today.

Comment 2

[Richard Newman [:rnewman]]

It was fun sleuthing!

Comment 3

[Nick Alexander :nalexander [he/him]]

Verification procedure: install Nightly from June 25th [1].  Create FxA + Sync account.  Witness new client GUID being uploaded.

Install Nightly from June 28th [2].  Sync.  Witness existing client GUID being downloaded:

I FxAccounts(4704)            fennec :: SyncClientsEngineStage :: Local client GUID exists on server and was downloaded.

Install (with -r -d, to allow downgrade) Nightly from June 27th [3].  Sync.  Witness no client GUID found, and new client GUID being uploaded:

I FxAccounts(5349)            gecko :: GlobalSession :: Running next stage syncClientsEngine (org.mozilla.gecko.sync.stage.SyncClientsEngineStage@42d44540)...
I FxAccounts(5349)            gecko :: SyncClientsEngineStage :: Local client GUID does not exist on the server. Upload timestamp will be reset.

[1] http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/2014-06-25-03-02-06-mozilla-central-android/fennec-33.0a1.multi.android-arm.apk

[2] http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/2014-06-28-03-02-01-mozilla-central-android/fennec-33.0a1.multi.android-arm.apk

[3] http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/2014-06-27-03-02-12-mozilla-central-android/fennec-33.0a1.multi.android-arm.apk

Comment 4

[Nick Alexander :nalexander [he/him]]

No further action needed.  Just some temporary discomfort for Nightly users who hit a 26th or 27th Nightly : it will take three weeks to TTL the duplicate records away.