1032659 - Don't use font-weight: lighter in gaia

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Michael Wu [:mwu]]

Bug 987872 will add a new version of Fira Sans, which introduces a number of very light weights. Due to the way font-weight is specified <http://dev.w3.org/csswg/css-fonts/#font-weight-prop>, this will cause most users of font-weight: lighter to switch to the lightest Fira Sans. Replacing lighter with 300 should maintain the look of things with the new set of fonts.

Comment 1

[Michael Wu [:mwu]]

Attachment: (PR) Replace font-weight: lighter with 300

s/font-weight: lighter/font-weight: 300/ in apps/ and shared/

Comment 2

[Michael Wu [:mwu]]

https://github.com/mozilla-b2g/gaia/commit/7da24d97aced3264bd35f87be2990fb8f86491ab

Comment 3

[Michael Wu [:mwu]]

This is necessary on any branch in which we've uplifted bug 987872. Otherwise certain strings use the wrong font weight and look way too light.

Comment 4

[Kai-Zhen Li [:seinlin][:kli]]

As per bug 1059213 comment 28, we don't need to uplift this bug to v2.0m.

Comment 5

[Kai-Zhen Li [:seinlin][:kli]]

Merge into v2.0m got conflicts.

Comment 6

[Michael Wu [:mwu]]

Attachment: (PR) Replace font-weight: lighter with 300 (v2.0m)

Comment 7

[Kai-Zhen Li [:seinlin][:kli]]

v2.0m: https://github.com/mozilla-b2g/gaia/commit/cf8132fae6d3f2777a031ff05e98679cbf2e2724

Comment 8

[Michael Wu [:mwu]]

[Blocking Requested - why for this release]:

Blocking was requested for bug 987872. If we land bug 987872 on 2.0, this is also required.

Comment 9

[Steven Yang [:styang]]

as triage. plus it.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Ping RE: Gaia v2.0 approval request?

Comment 11

[bhavana bajaj [:bajaj]]

Moving hte blocking flag to 2.0M+ for the same reason as stated here: https://bugzilla.mozilla.org/show_bug.cgi?id=987872#c100