Closed Bug 1032659 Opened 7 years ago Closed 7 years ago

Don't use font-weight: lighter in gaia

Categories

(Firefox OS Graveyard :: Gaia, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:2.0M+, b2g-v2.0 wontfix, b2g-v2.0M fixed, b2g-v2.1 fixed)

RESOLVED FIXED
2.0 S6 (18july)
blocking-b2g 2.0M+
Tracking Status
b2g-v2.0 --- wontfix
b2g-v2.0M --- fixed
b2g-v2.1 --- fixed

People

(Reporter: mwu, Assigned: mwu)

References

Details

Attachments

(2 files)

Bug 987872 will add a new version of Fira Sans, which introduces a number of very light weights. Due to the way font-weight is specified <http://dev.w3.org/csswg/css-fonts/#font-weight-prop>, this will cause most users of font-weight: lighter to switch to the lightest Fira Sans. Replacing lighter with 300 should maintain the look of things with the new set of fonts.
s/font-weight: lighter/font-weight: 300/ in apps/ and shared/
Attachment #8448507 - Flags: review?(timdream)
Attachment #8448507 - Flags: review?(timdream) → review+
https://github.com/mozilla-b2g/gaia/commit/7da24d97aced3264bd35f87be2990fb8f86491ab
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
This is necessary on any branch in which we've uplifted bug 987872. Otherwise certain strings use the wrong font weight and look way too light.
blocking-b2g: --- → 2.0M?
As per bug 1059213 comment 28, we don't need to uplift this bug to v2.0m.
blocking-b2g: 2.0M? → ---
Blocks: Woodduck
blocking-b2g: --- → 2.0M+
Merge into v2.0m got conflicts.
Flags: needinfo?(mwu)
Flags: needinfo?(mwu)
[Blocking Requested - why for this release]:

Blocking was requested for bug 987872. If we land bug 987872 on 2.0, this is also required.
blocking-b2g: 2.0M+ → 2.0?
as triage. plus it.
blocking-b2g: 2.0? → 2.0+
Ping RE: Gaia v2.0 approval request?
Flags: needinfo?(mwu)
Target Milestone: --- → 2.0 S6 (18july)
Moving hte blocking flag to 2.0M+ for the same reason as stated here: https://bugzilla.mozilla.org/show_bug.cgi?id=987872#c100
blocking-b2g: 2.0+ → 2.0M+
Flags: needinfo?(mwu)
You need to log in before you can comment on or make changes to this bug.