1032784 - Some MMI unit tests are broken

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Anthony Ricaud (:rik)]

1) [communications-dialer/test/unit/mmi_test.js] dialer/mmi Mmi message reply via UI Check request result:
     Uncaught Error: Error: expected null to equal 'success_mmi_msg' (http://test-agent.gaiamobile.org:8080/common/test/helper.js?time=1404218964053:31)
      at onerror (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4959:10)
  
  2) [communications-dialer/test/unit/mmi_test.js] dialer/mmi Mmi message reply via UI Check sessionEnded null:
     Uncaught Error: Error: expected true to equal null (http://test-agent.gaiamobile.org:8080/common/test/helper.js?time=1404218964053:31)
      at onerror (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4959:10)
  
  3) [communications-dialer/test/unit/mmi_test.js] dialer/mmi Mmi message reply via UI with multiple connections Check request result:
     Uncaught Error: Error: expected null to equal 'success_mmi_msg' (http://test-agent.gaiamobile.org:8080/common/test/helper.js?time=1404218964053:31)
      at onerror (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4959:10)

  4) [communications-dialer/test/unit/mmi_test.js] dialer/mmi Mmi message reply via UI with multiple connections Check sessionEnded null:
     Uncaught Error: Error: expected true to equal null (http://test-agent.gaiamobile.org:8080/common/test/helper.js?time=1404218964053:31)
      at onerror (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4959:10)


I've confirmed that this is because of bug 1021481.

I also don't understand why it doesn't show up on Travis or TBPL.

Comment 1

[Gabriele Svelto [:gsvelto]]

My patch for bug 1016885 contains a fix for this as I hit the problem while developing that one.

Comment 2

[Gabriele Svelto [:gsvelto]]

I've removed the changes regarding this bug from my patch for bug 1016885 because they caused issues on Travis. To sum it up I get this behavior currently:

- Using 'app://communications.gaiamobile.org' works on Travis but fails locally

- Using 'https://communications.gaiamobile.org:8080' works locally but fails on Travis

Meh :-(

Comment 3

[Anthony Ricaud (:rik)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/21367

I'm trying this pull request to see what happens.

Comment 4

[Anthony Ricaud (:rik)]

Comment on attachment 8450549 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/21367

Yup, green locally and on Travis.

Comment 5

[Anthony Ricaud (:rik)]

https://github.com/mozilla-b2g/gaia/commit/14bbf54ead1632ae5b77423db30e43689289a3a2

Comment 6

[Julien Wajsberg [:julienw]]

(In reply to Gabriele Svelto [:gsvelto] from comment #2)
> I've removed the changes regarding this bug from my patch for bug 1016885
> because they caused issues on Travis. To sum it up I get this behavior
> currently:
> 
> - Using 'app://communications.gaiamobile.org' works on Travis but fails
> locally
> 
> - Using 'https://communications.gaiamobile.org:8080' works locally but fails
> on Travis
> 
> Meh :-(

The same happens for apps/settings/test/unit/panels/app_permissions/app_permissions_list_test.js

But I'd like to understand why it works for travis... I tried to generate a new profile, ran make clean, updated my nightly, etc.

Sherman, can you help about this?

Comment 7

[Sherman Chen [:chens] (inactive)]

From what I know, there is a before_script for travis to prepare the environment before running tests, and changes made to support app protocol running on travis are here, https://github.com/mozilla-b2g/gaia/commit/43fd8f8bff1f774cf5e9f9d8d3bbcfa2d4a30367#diff-0ecff94ae42cf9ce8e3bffc22682d9c7L22

And for running tests locally, we may also point the location to app://test-agent.gaiamobile.org instead of http://test-agent.gaiamobile.org:8080.

Comment 8

[Julien Wajsberg [:julienw]]

Thanks for pointing this Sherman, it was too obvious I guess.

We should probably change bin/gaia-test then. And you should definitely have sent a mail to the mailing list :(

Comment 9

[Sherman Chen [:chens] (inactive)]

Ah... I forgot to change bin/gaia-test and mailing list as well, thanks Julien!