1025631 - Incomplete visual refresh for USSD screen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[:gerard-majax]

Attachment: 2014-06-15-16-00-55.png

The bottom of the USSD screen when displaying error, at least, is not properly displayed.

STR:
 0. Send an invalid USSD request

Expected:
 USSD screen should be completely styled

Actual:
 Some elements are not styled.

Check the bottom of the attached screenshot.

Comment 1

[Anthony Ricaud (:rik)]

This might be a visual refresh regression.

Comment 2

[:gerard-majax]

Attachment: 2014-06-15-16-08-11.png

I also see this when having the proper USSD menu, so it's on all cases.

Comment 4

[Jason Smith [:jsmith]]

QA Wanted to check 1.4.

Comment 5

[Anthony Ricaud (:rik)]

We need a regression window here to know what created this problem.

Comment 6

[Jason Smith [:jsmith]]

(In reply to Anthony Ricaud (:rik) from comment #5)
> We need a regression window here to know what created this problem.

We branch check first. Then we consider doing a window. I don't want multiple keywords on the bug - that causes delays to get QA requests complete.

Comment 7

[Maria Angeles Oteo (:oteo)]

Arnau or Paco, can you have a look at it?

Comment 8

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

clearing info as Paco already took it :)

Comment 9

[Paco Rampas [:paco]]

Attachment: patch in github

Comment 10

[Paco Rampas [:paco]]

Attachment: ussd-screen.png

Comment 11

[Anthony Ricaud (:rik)]

Comment on attachment 8448538 [details] [review]
patch in github

Can we get rid of the extra <p> inside #response?

I don't like the combinaison of position: absolute and moz-calc to lay out this screen. This is because we have to repeat the sizes of the elements so that's hard to maintain and could be out of sync. Can you convert that to flexbox instead?

Comment 12

[Paco Rampas [:paco]]

(In reply to Anthony Ricaud (:rik) from comment #11)
> Comment on attachment 8448538 [details] [review]
> patch in github
> 
> Can we get rid of the extra <p> inside #response?

This is needed for the input with reset button. This comes from BB.

> I don't like the combinaison of position: absolute and moz-calc to lay out
> this screen. This is because we have to repeat the sizes of the elements so
> that's hard to maintain and could be out of sync. Can you convert that to
> flexbox instead?
Yeah! It is done on updated patch. And also, I answered you on github about the other question.

Comment 13

[Anthony Ricaud (:rik)]

Comment on attachment 8448538 [details] [review]
patch in github

Thanks for the explanations.

r+ with that simpler selector change.

Comment 14

[Anthony Ricaud (:rik)]

Landed! https://github.com/mozilla-b2g/gaia/commit/75b1de1c0b0b37f720576d3db5e06eb80e0032b8

Comment 15

[Loli (:lolimartinezcr)]

Tested and working
Hamachi
2.1
Gecko-a777777
Gaia-049853b

Comment 16

[Loli (:lolimartinezcr)]

Attachment: IMG_0010.jpg

Comment 17

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/367a87f3d0c701227d955fb90469fa69ea9ed4a4

Comment 19

[Elie]

Attachment: VIDEO0139_Compress.MP4

This issue has been successfully verified on Flame 2.0:
Gaia-Rev        3aa0797c111a40e36f722722309668de3d469181
Gecko-Rev       93efc8b4155f0a4a50eaad19acbb95ec24139e63
Build-ID        20141204050313
Version         32.0
Device-Name     jrdhz72_w_ff
FW-Release      4.4.2

This issue has been successfully verified on Flame 2.1:
Gaia-Rev        dbaf3e31c9ba9c3436e074381744f2971e15c7bf
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/ebce587d2194
Build-ID        20141203001205
Version         34.0
Device-Name     flame