1033127 - [B2G][v1.4]it will always ask user to select sim before calling in call log even if the default sim for outgoing call had been set yet

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Dialer, defect, P3)

Description

[helloarvin]

Steps to reproduce:

1) Insert both  sim card and boot the phone;
2) Now In SIM MANAGEMENT Set the SIM1 for outgoing call;
3) Now From call log click on number to make call;

Actual results:

Still ask form which sim call have to be made.

Expected results:

to make call via default simcard directly without asking for pick

Comment 1

[helloarvin]

Attachment: no-need-ask-for-sim-picking.patch

As Anthony's comment in bug1014043 ---'it would make more sense to respect the user setting', We should add the judgement of current cardIndex got from 'ril.telephony.defaultServiceId' and if its value is '-1'(two possible case: 'no sim' or 'always ask') we should call CallHandler.call directly with no asking.

Now i submit a patch for the issue and ask Anthony and Etienne to give some feedback, thanks a lot.

Comment 2

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8449122 [details] [diff] [review]
no-need-ask-for-sim-picking.patch

This is actually expected behavior since we don't indicate anywhere to the user what SIM the call will be placed on. In every other case, we have a SIM indicator on the dial button.

But aside from that, this is the wrong fix. -1 corresponds to the "always ask" option, and 0 upwards corresponds to a specific SIM. This will result in calls on an invalid SIM. What you would actually want, in this case, is to check if cardIndex !== -1.

(I'm clearing f? Etienne and Anthony as I don't think it's needed with my comment, but feel free to put it back if you want.)

Comment 3

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8449122 [details] [diff] [review]
no-need-ask-for-sim-picking.patch

Okay, I read Anthony's comment in bug 1014043 comment 11 and I don't agree, though I don't feel strongly about this. My reasoning is that the user might expect that it will call this contact/number back on the SIM that they originally had contact with, but we don't do that, we just call on the SIM that the user set in their settings. Anthony, what do you think of this?

Regardless, it's an incorrect fix.

Comment 4

[helloarvin]

Hi Sherk,

Thank you very much for kindly feedback.

Now, I think we should discuss the most reasonable scheme for the scene before proceeding any further.

Scheme1: always ask user to select SIM before dialing on Call log (Reason is that user might expect that it will call this contact/number back on the SIM that they originally had contact with);

Scheme2: call directly via the default SIM in settings and ask user for SIM picking only when the default choice is 'Always ask' in settings (Reason is that user might feel the settings does not work if he/she has specified the default SIM for call already)

Both the schemes are sound from their own viewpoint, and I am prone to choose Scheme2 for 'it would make more sense to respect the user setting'.

Let's have a look the opinions of others.

Comment 5

[Anthony Ricaud (:rik)]

Before arguing if this is the right UX or not, I'd rather wait to see if this is a 1.4+ blocker. IMHO, we shouldn't block the release on this. The user can make a phone call, it might be a bit painful but it's not a broken functionality.

Comment 6

[helloarvin]

For my part, I insist that the issue should be a 1.4+ blocker. Because it will give user a false impression that settings function is not working fine. Especially, it's quite confusing to user for the phone behaves differently between Calllog and other dialing scene under the same settings.

Do you think so?

Comment 7

[Wayne Chang [:wchang]]

As described in the comments, this is the designed behaviour. 
The user is prompted to select a sim regardless, there is no risk to the user and the impact is minimal.

Comment 8

[helloarvin]

(In reply to Wayne Chang [:wchang] from comment #7)
> As described in the comments, this is the designed behaviour. 
> The user is prompted to select a sim regardless, there is no risk to the
> user and the impact is minimal.

Dear Wayne,
Please look through the comment #2, #3 and bug 1014043 comment 11, then you'll find that this is not the designed behavior in v1.4. 

Dear Doug,
I wonder if there's any spec for call log to follow just like [1] and then we could have a fairly clear idea of the necessity for the issue.

Thanks.

[1] https://bug920011.bugzilla.mozilla.org/attachment.cgi?id=8403783

Comment 9

[Wayne Chang [:wchang]]

I still find prompting for user to choose the SIM making more sense.
An example scenario would be:

- User sets SIM1 as default SIM
- User receives a call on SIM2
- User taps the item in call log to return a call

In this case, I as a user may want to use different SIM depending on various factors.

- If SIM2 is a business number or if I do not wish for this person to have my SIM1 number, I will need to call back with SIM2.
- If SIM1 gives me better rates and I do not care who the other person sees calling, then I would use SIM1.

Have discussed with UX and what you're seeing now is expected on 1.4.
Post 1.4 the behaviour would be different but still allows the user to select the SIM to dial out with.

ni?UX/Carrie

Comment 10

[Carrie Wang [New account: [e-mail]]]

Hi I believe that we've discussed this issue before on bug 983089. 
https://bugzilla.mozilla.org/show_bug.cgi?id=983089

For unknown numbers, I'd suggest replacing the "call" on action menu with two buttons, one is "Call via SIM 1" and the other is "Call via SIM 2" . For existing contacts, contact details will slide in and users can select SIM on that page. Thanks!

Comment 11

[Doug Sherk (:drs) (inactive)]

I agree with Wayne.

I don't think this is really worth the work for what Carrie has proposed. But if it's implemented, I'll review it.

Comment 12

[Anthony Ricaud (:rik)]

(In reply to Doug Sherk (:drs) from comment #11)
> I don't think this is really worth the work for what Carrie has proposed.
I'll add that I don't think it's not worth the risk, this late in 1.4.

Comment 13

[Anthony Ricaud (:rik)]

Correction: I'll add that I don't think it's worth the risk, this late in 1.4.
(negations are hard!)

Comment 14

[Doug Sherk (:drs) (inactive)]

I'm leaving this open in case a patch is written by someone else and a partner wants to cherry-pick it.

Comment 15

[helloarvin]

Change owner to Ricaud, thanks.

Comment 16

[Anthony Ricaud (:rik)]

It's not a 1.4 blocker so I'm not planning to work on this. If it becomes a blocker, we'll assign to someone.

Comment 17

[helloarvin]

Wontfix according to the above discussions.