1033264 - Middle mouse click on a job behaves differently to TBPL

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[Ed Morley [:emorley]]

In TBPL, a middle mouse click opens a new tab immediately, pointed at the parsed log view.

In Treeherder, middle clicking on a job results in just the "auto-scroll" overlay icon being displayed initially, and then after a pause, a new tab opens pointing to the raw log. The auto-scroll icon doesn't go away.

Please can we eliminate the pause, change the URL to the treeherder log viewer & prevent the auto-scroll icon from appearing?

Comment 1

[Jonathan French (:jfrench)]

I might have a look at this if I get time. In any case, the event appears to be defined here
https://github.com/mozilla/treeherder-ui/blob/01060d5fe9410613ea84ba186bdaaad466660aba/webapp/app/js/providers.js#L190

Comment 2

[Jonathan French (:jfrench)]

I'll see if I can sort this one out.

Comment 3

[Jonathan French (:jfrench)]

I've been fairly challenged by this one, so I'm going to un-assign myself for now, in case someone else wants to grab it. Otherwise I might revisit it later. However I do have a patch which

o fires the structured log on the MMB
o appears to suppress the browser-navigation icon
o fires the raw log on RMB as requested in bug 1032499

But - it doesn't address the context menu persistence noted in the description comment "a)" in bug 1032499. To address that, plus the stuff above, we believe requires:

o an injected href into the job element pointing to the structured log
o a new click event handler on LMB to avoid re-directing to the href and instead opening the job details
o an agreement that the raw log will no longer be available on the "other" button(RMB) by this means, since the context menu will interpret the href link and open the structured log as a "Open in New Tab", etc.

Presumably if users want the raw log, they will either have to click on the raw log icon in the job details bar, or the raw log icon in the structured logviewer spawned by the above MMB.

Comment 4

[David Burns :automatedtester]

Attachment: Prevent auto-scroll when doing middle click

Comment 5

[David Burns :automatedtester]

https://github.com/mozilla/treeherder-ui/commit/d9a5932441dd426b43eb3aa9a0064e3ff30c16d0

Comment 6

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/5f94e9fcc21423814897463af1204f93795df87d
Bug 1033264: Prevent auto-scroll when doing a middle click

https://github.com/mozilla/treeherder/commit/63017a32b73bb3df860a2c1d18fa3674da952bda
Merge pull request #158 from AutomatedTester/1033264

Bug 1033264: Prevent auto-scroll when doing a middle click