1033318 - [MSISDN Authentication][System] International prefix duplicated

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[mbarone]

Attachment: device-2014-07-02-122558.png

STR

Pre-Condition: Device without SIM

1. Open Loop app and register into the app using the option "Phone Number"
2. In the drop-down list for the international prefix select the prefix.

ACTUAL RESULT
In the drop down list many prefix are duplicated (i.e. +1, or +44, etc). See attachment

EXPECTED RESULT
The list should not contain duplicated fields.

Comment 1

[Jason Smith [:jsmith]]

If this is a Loop-specific bug, then this shouldn't block, given that's not requiring core build changes. We should figure another way to track the work required here though to deploy the mobile client on marketplace.

Comment 2

[Borja Salguero [:borjasalguero]]

(In reply to Jason Smith [:jsmith] from comment #1)
> If this is a Loop-specific bug, then this shouldn't block, given that's not
> requiring core build changes. We should figure another way to track the work
> required here though to deploy the mobile client on marketplace.

This is not related with Loop, it's related with MSISDN Authentication flow.

It's true that several MCC are related with the same 'Country Code', so it would be great to show the name of the 'Region' instead of the Country Code, in order to choose the right one. Renaming & assigning to me! Thanks!

Comment 3

[Gregor Wagner [:gwagner]]

Is the international prefix drop-down a system wide feature?

Comment 4

[Gregor Wagner [:gwagner]]

Any updates here? This needs to get in by next week or it won't be in 2.0

Comment 5

[Borja Salguero [:borjasalguero]]

Guillermo is going to take a look to this bug. Thanks!

Comment 6

[Guillermo López :willyaranda (probably SLOW response)]

Attachment: Patch

Comment 7

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8454398 [details] [review]
Patch

Thanks Guillermo!

Comment 8

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/gaia/commit/b422bc5f15c18fd4c683d2eddc72d659abc490cf

Comment 9

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/752cd79947243a8f6d673acd8b66f1c7ea07da1e

Comment 10

[sarsenyev]

Verified the issue is fixed on 2.0 and 2.1

No duplicated International prefix appears on the drop off menu in "Loop" app

"Flame 2.0

Device: Flame 2.0 (319mb)(Kitkat Base)(Shallow Flash)
Build ID: 20141118000207
Gaia: 1ede2666f1e6c1b3fd3b282011caf0cbc59544b0
Gecko: 2bea026d4f86
Version: 32.0 (2.0)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0"

"Flame 2.1 

Device: Flame 2.1 (319mb)(Kitkat Base)(Shallow Flash)
BuildID: 20141118001204
Gaia: 1b231b87aad384842dfc79614b2a9ca68a4b4ff3
Gecko: 95fbd7635152
Version: 34.0 (2.1)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0"