Closed Bug 1033328 Opened 10 years ago Closed 10 years ago

Toggling "show only unclassified failures" is slower than TBPL

Categories

(Tree Management :: Treeherder, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: camd)

References

Details

(Keywords: perf)

Attachments

(1 file)

49 bytes, text/x-github-pull-request
Details | Review
1) Go to https://treeherder.mozilla.org/ui/#/jobs?repo=mozilla-inbound
2) Wait for the page to fully load
3) Press the 'u' key (to toggle showing only unclassified failures)
4) Observe time taken for the UI to update
5) Repeat steps 2-4 with https://tbpl.mozilla.org/?tree=Mozilla-Inbound

Expected:
Same time or quicker than TBPL for the UI to update

Actual:
TBPL updates virtually instantly (fast enough it's hard to time). Treeherder takes~2 seconds.
Assignee: nobody → cdawson
Status: NEW → ASSIGNED
This is fixed in https://github.com/mozilla/treeherder-ui/commit/dbc7d5c22481df76057289d53649dc61aab6afd0

As the commit message states, this may not be quite as fast as TBPL, but should bring the speed into an acceptable range.  The speed will totally depend on the number of jobs in the visible resultsets.  For the default of 10 on Mozilla Central when there are a huge number of jobs, we are now less than 1 second.  Fewer jobs will be much faster.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Attached file pull request
Much better, thank you :-)
Keywords: perf
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/6678e359c84e73a8778d2744444cf8e60e55f77c
fix bug 1033328: Class based filtering with jquery selectors now working

Also fixes bug 1033330 and bug 1043783 as they were related to the work for this perf improvement.
The speed improvements here may not be quite as fast as TBPL, but they should be at an acceptable level.
This changes our filtering mechanism to use JQuery selectors to set jobs, groups and platforms vislble or not.
This also contains some refactoring to make some functions more reusable and prevent circular references in our classes.
You need to log in before you can comment on or make changes to this bug.